oplock probs.

[Jeremy Allison]

Manish Agarwal wrote:
> 
> Hi,
> 
> I noticed a few problems with oplocks in samba-2.0.6 and I think I have
> it fixed. The problems that the patch tries to fix are:
> 
> 1. Level2 oplocks should be broken on a LOCKING_ANDX request which
> contains record lock request. I don't think the SMB draft mentions this,
> but I see the NT server doing this. To me it makes sense to do it.
> 2. If the client, on being sent an oplock break message (break to
> LEVEL2), flushes a write or a lock(i.e. does a write or a lock before it
> acknowledges the oplock break), then the server should further break the
> oplock to NONE by sending another oplock break message (break to NONE).
> Not doing this can lead to some problems which become evident when you
> have mandatory locking.
> 3. The server should not break the client's level2 oplock on a write, if
> that client is the only one holding an oplock on the file.
> 
> I have confirmed that the NT server does this and if anyone is
> interested I
> can post some traces for Samba and NT server for the above cases.

I know it's been a while, but could you send me those traces
please ?

This fix was too big to make it into 2.0.7 at the late
stage we got it, but I'd like to address this for 2.0.8,
HEAD & TNG.

Thanks,

	Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------