Debug Enhancement Suggestion, SAMBA 2.0.6

John E. Malmberg wb8tyw at qsl.net
Thu May 4 00:57:15 GMT 2000


I am recommending that the DEBUG statements from REPLY.C be modified to
contain an additional parameter that describes the starting location in the
file that the read transaction starts at.

I needed this information to find a bug in my code.  It helped me understand
that when Windows NT is copying a file from a server, that it does not
request the sections of the file in sequential order.

 (new) REPLY.C;3
 2282
 2283     DEBUG( 3, ( "read fnum=%d start=%d num=%d nread=%d\n",
 2284               fsp->fnum, (int)startpos, (int)numtoread,
(int)nread ) );
 2285
******
(old) REPLY.C;2
2282
 2283     DEBUG( 3, ( "read fnum=%d num=%d nread=%d\n",
 2284               fsp->fnum, (int)numtoread, (int)nread ) );
 2285
************

(new) REPLY.C;3
 2346
 2347     DEBUG( 3, ( "read fnum=%d start=%d num=%d nread=%d\n",
 2348               fsp->fnum, (int)startpos, (int)smb_maxcnt,
(int)nread ) );
 2349
 2350     return chain_reply(inbuf,outbuf,length,bufsize);
******
(old) REPLY.C;2
 2346
 2347     DEBUG( 3, ( "readX fnum=%d min=%d max=%d nread=%d\n",
 2348                 fsp->fnum, (int)smb_mincnt, (int)smb_maxcnt,
(int)nread ));
 2349
 2350     return chain_reply(inbuf,outbuf,length,bufsize);
************

Thank you,
-John
wb8tyw at qsl.network

Samba Version: 2.0.6 (I hope to get to 2.0.7 soon)
Platform: OpenVMS/ALPHA 7.2.
Compiler: DEC C 6.0




More information about the samba-technical mailing list