coding volunteers needed for msrpc server-side API conversion

Luke Kenneth Casson Leighton lkcl at samba.org
Thu Jan 27 19:39:46 GMT 2000


> In cli_*.c we do:
> 
> xxx_xxx(const foo in, foo **out)
> 	xxx_make_q_xxx(in) /* this one dups all the neccessary things */

elrond,
k
thi is not acceptable for the SPOOLSS functions, which pass in a
stupid-wasted buffer as an [in out] parameter.

the buffer size could potentiallly be several megabytes in size.  NT has a
hard-limit of 5mb on dce/rpc data and a hard-limit of unknown size in
SPOOLLSS but they got it wrong.  [if you send a request with 1mb of
spoolss data you will terminate spoolss.exe].

anyway, the upshot is that it's not really ok to dup() [in] and [in out]
parameters.

luke



More information about the samba-technical mailing list