TNG: making %U work again for logon path et. al.

[Patrick J. LoPresti]

Luke Kenneth Casson Leighton <lkcl at samba.org> writes:

> patrick, i added your patch in already.

Look again.  This is a different patch.

> and the correct fix is to make get_sec_ctx() read the right
> vuser_key so that standard_sub_vuser() can "grab" the right info.
> 
> which means a bit of a catch-22 situation, as it's confusing to
> create the right info at the right point.

Right, we kind of want this information before the user has
authenticated...

> for preference, the %U etc should be substituted in srv_netlogon.c
> in the netr_sam_logon function, but THAT means we need a Unicode
> version of standard_sub_vuser() and standard_sub_basic()!!!

Yuck.  Couldn't the Unicode conversion be the final step?  So the
sequence would be 1) authenticate, 2) perform substitutions, 3)
convert to Unicode...

 - Pat