bug in Samba207 smbd/process.c?

Ying Chen ying at almaden.ibm.com
Fri Dec 1 17:49:00 GMT 2000


Hi,

I'm wondering if the following is a bug in Samba207:

In smbd/process.c line 1066:
============================================================
if((num_smbs % 200) == 0) {
        time_t new_check_time = time(NULL);
-        if(last_timeout_processing_time - new_check_time >
= (select_timeout/1000)) {
+       if(new_check_time - last_timeout_processing_time >
= (select_timeout/1000)) {
          if(!timeout_processing( deadtime, &select_timeout,
&last_timeout_processing_time))
            return;
          num_smbs = 0; /* Reset smb counter. */
          last_timeout_processing_time = new_check_time; /* Reset time. */
        }
      }
============================================================

Shouldn't "+" line be correct instead of the "-" line, otherwise,
timeout_processing would never be called?

Regards,

Ying Chen





More information about the samba-technical mailing list