VFS unlink not being called

Brad Sahr bsahr at macromedia.com
Sat Aug 26 01:26:14 GMT 2000


It looks like reply_unlink() in reply.c also bypasses
an installed VFS. Deleting a file on the VFS mediated
share goes through the following code segment which
does not call the VFS. It looks like if has_wild is
true, the VFS unlink operation will be called, but I 
haven't been able to do anything at the client to 
cause this to happen.

** code segment from reply_unlink() in reply.c **
  if (!has_wild) {
    pstrcat(directory,"/");
    pstrcat(directory,mask);
    if (can_delete(directory,conn,dirtype) && !dos_unlink(directory))
      count++;
    if (!count)
      exists = vfs_file_exist(conn,directory,NULL);    
  } else {
  ...
  }

Would it be reasonable to replace the dos_unlink() call with
a call to the vfs_ops.unlink() as is done later in the code?

Brad





More information about the samba-technical mailing list