Bug I found is NOT getting into CVS

Ron Alexander rcalex at home.com
Thu Aug 10 14:27:12 GMT 2000


Fellow developers,

First off, know that I do not use Unix in any flavour (this is from the
Stratus VOS port). I do not know CVS. I do not use diff, gcc make, gmake or
make files.

I found and had confirmed by David Collier-Brown a bug in smb.h (code now in
smb_macros.h)

I just checked at this URL http://samba.org/cgi-bin/cvsweb/samba/ and do NOT
see the changes. Both myself and David have sent several requests to get
these minor changes made.

Funky code

/* assert macros */
#define SMB_ASSERT(b) ((b)?(void)0: \
        (DEBUG(0,("PANIC: assert failed at %s(%d)\n", \
		 __FILE__, __LINE__)), smb_panic("assert failed")))

Correct code

/* assert macros */
#define SMB_ASSERT(b) ((b)?0: \
        (DEBUG(0,("PANIC: assert failed at %s(%d)\n", \
		 __FILE__, __LINE__)), smb_panic("assert failed")))

I repeat, I am unable to do what is asked in the bug reporting documentation
since I do not use Unix (this is from the VOS port) and do not have the
tools mentioned.

It would be real nice to get a reply that says either:
1. We are not going to make the change because we don't believe either you
or David Collier-Brown.
2. The change is made, and is here ->(the URL where I can see it)
3. The change will be made by some date. I will then check on that date.

Ron Alexander





More information about the samba-technical mailing list