problem in smbclient with Japanese

[Hiroshi MIURA]

I found the problem with smbclient and Japanese.

A smbclient has a option '-t '(TERM), that specify the charcode for display. 
But it has no effect on the command line.

We, Japanese, use the Japanese KANJI code in command line as Service Name.
Microsoft Japan K.K. implements Windows family OSs that allows 
the KANJI service names.

It is NOT GOOD that we must specify the service name by the Charcode specified 
in smb.conf. It is GOOD to write one using terminal code spedified '-t' option. 

I attached the patch. it is for cvs SAMBA2_0 and head branch.


One more idea...

If 'smbstatus' command have same option '-t'(TERM), it may be useful for
Japanese users. I starts discussion on Japsese samba users groups' ML.
If it is accepted by Japanese users, I will make patch. (and will post here...)

Hiroshi

--- client.c.keep	Wed Aug  9 00:12:17 2000
+++ client.c	Wed Aug  9 00:12:37 2000
@@ -2308,16 +2308,8 @@
   
 	if (*argv[1] != '-') {
 		pstrcpy(service,argv[1]);  
-		/* Convert any '/' characters in the service name to '\' characters */
-		string_replace( service, '/','\\');
 		argc--;
 		argv++;
-		
-		if (count_chars(service,'\\') < 3) {
-			usage(pname);
-			printf("\n%s: Not enough '\\' characters in service\n",service);
-			exit(1);
-		}
 
 		if (argc > 1 && (*argv[1] != '-')) {
 			got_pass = True;
@@ -2444,6 +2436,18 @@
 
 	if (*term_code)
 		interpret_coding_system(term_code);
+	
+	unix_to_dos(service, True);
+	unix_to_dos(desthost, True);
+	/* Convert any '/' characters in the service name to '\' characters */
+	string_replace( service, '/','\\');
+		
+	if (count_chars(service,'\\') < 3) {
+		usage(pname);
+		printf("\n%s: Not enough '\\' characters in service\n",service);
+		exit(1);
+	}
+
 
 	if (!tar_type && !*query_host && !*service && !message) {
 		usage(pname); 
-- 
SAMBA User Group Japan,  staff    http://www.samba.gr.jp/
Linux Kernel Hack Japan 	http://lkh.linux.or.jp/ (Now Constructing)
Project BLUE 			http://www.blue.gr.jp/
LUGS:=YLUGダイエット部,TLUC関東支部,TLUG,CLUG,たん清,ダンケ,すぃすぃ
三浦広志 ----- MIURA, Hiroshi 		http://www.momokuri.org/