very small bug fix.

Branko Čibej branko.cibej at hermes.si
Tue Apr 18 11:03:22 GMT 2000


Kenichi Okuyama wrote:

> This will not take any effect as long as you're using unix, but it
> might on some other OS. So, since I found it, I'll report it :p
> 
> here is diff(simple, isn't it :p )
> 
> # diff loadparm.c.orig loadparm.c
> 
> 1118c1118
> < static TALLOC_CTX *lp_talloc;
> ---
> > static TALLOC_CTX *lp_talloc = NULL;

This is not OS-dependent, it's language-dependent. In C,
global and static data must be initialized to zero.


Oh, yes; it might cause problems on architectures where the
null pointer representation does not have all bits zero.
So maybe your fix is necessary, if there are any such
architectures around today (and if Samba runs on any of them) ...

-- 
Branko Čibej                 <branko.cibej at hermes.si>
HERMES SoftLab, Litijska 51, 1000 Ljubljana, Slovenia
voice: (+386 1) 586 53 49     fax: (+386 1) 586 52 70


More information about the samba-technical mailing list