BUG/PATCH: Samba 2.0.7pre3

Jeremy Allison jeremy at valinux.com
Wed Apr 12 23:02:10 GMT 2000

Mattias Gronlund wrote:
> Hello,
> There is a bug in SAMBA that can make smbd to write the log-disk full. The "max log size"
> limit should be checked periodically if you read the man page, but the the code skips all these
> tests if smbd is not running as root when the check should be done.
> This is a real problem, we had a few disk-full problems before this patch.

I like this patch (I'm considering it for 2.0.7 - which
was feature frozen dammit ! :-), but I'd like to change
it to do the check in the timeout loop in main, not where
you currently have it which is within the main packet
receive loop.

The problem is it will add many become_root()/unbecome_root()
pairs to the main codepath if it isn't done in the timeout
loop, and these are *expensive* in performance (as Herb and I
found to our cost at SGI... :-).


Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba-technical mailing list