poking/prodding utmp

[Jeremy Allison]

David Lee wrote:
> 
> I hope you have seen that the patch (for 2.0.7pre3) is now available.
> Notes at:
>     http://www.dur.ac.uk/~samba/utmp-207pre3.2.htm
> and patch at:
>     http://www.dur.ac.uk/~samba/utmp-207pre3.2.patch
> 
> (the ".2" is version 2 of my patch).
> 
> 1.  Although it has utmp consolidate (please test), it still uses the
>     sparse numbering scheme.  I believe that your "next sequential slot"
>     code has a race condition, between finding the slot and grabbing it.
>     (imagine connections arriving simultaneously in different processes
>     and the CPU timeslicing between the finds and grabs).  So for the
>     moment I think we'll have to miss on that particular feature.
> 
> 2.  Rather than using your new function in "conn.c" to count connections
>     within the process, it uses an exisitng one.  It seems to work.
> 
> Could you try the patch and report back?  (Jeremy is keen to move quickly
> on incorporating it.)  Thanks.

Ok - Giulio, can you let me know if this patch
works for you ?

Anyone else, can you help me with a yes/no decision
on this patch. I can make sure it applies and builds
cleanly, but I'm not an expert on the functionality.

Regards,

	Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------