ideas for multiple group macro expansion

Nicolas Williams Nicolas.Williams at wdr.com
Wed Mar 17 22:00:28 GMT 1999


Sure. Here it is. I hadn't sent it in because I figured the 1.9.x branch
was closed.

Then again, I believe the same bug is present in Samba 2.0 and probably
all 2.x versions. So maybe this patch will apply fairly cleanly to 2.x
source.

Nico

ksh[319]% diff loadparm.c /tmp/samba-1.9.18p10-sbc/source/
152d151
<   char *szNetbiosName;
480c479
<   {"netbios name",     P_STRING,  P_GLOBAL, &Globals.szNetbiosName,     NULL,   NULL},
---
>   {"netbios name",     P_UGSTRING,P_GLOBAL, myname,                     NULL,   NULL},
971d969
< FN_GLOBAL_STRING(lp_netbios_name,&Globals.szNetbiosName)
ksh[320]% diff nmbd.c /tmp/samba-1.9.18p10-sbc/source/    
458,462c458
<     fstrcpy( myname, lp_netbios_name() );
<     if (! *myname)
<     {
<       fstrcpy( myname, myhostname );
<     }
---
>     fstrcpy( myname, myhostname );
ksh[321]%


On Wed, Mar 17, 1999 at 01:37:25PM -0800, Jeremy Allison wrote:
> Nicolas Williams wrote:
> > 
> > We make much use of %$(env var name) syntax in smb.conf.
> > 
> > Oh, and fix the 'netbios name' parameter to allow %$() syntax. I've done
> > this for Samba 1.9.18p10, which we use here.  :)
> 
> Can you send me that patch please (if I had it I may
> have lost it :-( ).
> 
> Thanks,
> 
> 	Jeremy.
> 
> -- 
> --------------------------------------------------------
> Buying an operating system without source is like buying
> a self-assembly Space Shuttle with no instructions.
> --------------------------------------------------------


More information about the samba-technical mailing list