samba 2.0.3 Solaris compile error

[Stefan Nehlsen]

As somebody else reported in the newsgroup, Samba 2.0.3 will not compile
on Solaris with --with-nisplus:

$ ./configure --with-automount --with-nisplus-home --with-nisplus

$ make
Using FLAGS =  -O -Iinclude -I./include -I./ubiqx -I./smbwrapper -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DSMBLOGFILE="/usr/local/samba/var/log.smb" -DNMBLOGFILE="/usr/local/samba/var/log.nmb" -DCONFIGFILE="/usr/local/samba/lib/smb.conf" -DLMHOSTSFILE="/usr/local/samba/lib/lmhosts"   -DSWATDIR="/usr/local/samba/swat" -DSBINDIR="/usr/local/samba/bin" -DLOCKDIR="/usr/local/samba/var/locks" -DSMBRUN="/usr/local/samba/bin/smbrun" -DCODEPAGEDIR="/usr/local/samba/lib/codepages" -DDRIVERFILE="/usr/local/samba/lib/printers.def" -DBINDIR="/usr/local/samba/bin" -DHAVE_INCLUDES_H -DPASSWD_PROGRAM="/bin/passwd" -DSMB_PASSWD_FILE="/usr/local/samba/private/smbpasswd"
Using FLAGS32 =  -O -Iinclude -I./include -I./ubiqx -I./smbwrapper -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DSMBLOGFILE="/usr/local/samba/var/log.smb" -DNMBLOGFILE="/usr/local/samba/var/log.nmb" -DCONFIGFILE="/usr/local/samba/lib/smb.conf" -DLMHOSTSFILE="/usr/local/samba/lib/lmhosts"   -DSWATDIR="/usr/local/samba/swat" -DSBINDIR="/usr/local/samba/bin" -DLOCKDIR="/usr/local/samba/var/locks" -DSMBRUN="/usr/local/samba/bin/smbrun" -DCODEPAGEDIR="/usr/local/samba/lib/codepages" -DDRIVERFILE="/usr/local/samba/lib/printers.def" -DBINDIR="/usr/local/samba/bin" -DHAVE_INCLUDES_H -DPASSWD_PROGRAM="/bin/passwd" -DSMB_PASSWD_FILE="/usr/local/samba/private/smbpasswd"
Using LIBS = -lsec -lsocket -lnsl -ldl  -lpam
Compiling smbd/noquotas.c
Compiling passdb/nispass.c
passdb/nispass.c: In function `add_nisp21pwd_entry':
passdb/nispass.c:387: parse error before string constant
passdb/nispass.c: At top level:
passdb/nispass.c:688: warning: initialization from incompatible pointer type
make: *** [passdb/nispass.o] Error 1

This error is cause by this:

        if (new_obj.zo_data.objdata_u.en_data.en_cols.en_cols_val == NULL)
        {
                DEBUG(0, "Memory allocation failure in add_nisp21pwd_entry()\n");
                return False;
        }

It will compile if you change it to:

        if (new_obj.zo_data.objdata_u.en_data.en_cols.en_cols_val == NULL)
        {
                DEBUG(0, ("Memory allocation failure in add_nisp21pwd_entry()\n"));
		 return False;
        }

We don't use this feature here, so I don't tested if it works.


cu, Stefan