Incrdible inefficiency in clitar

[Richard Sharpe]

Hi,

I was just watching an smbclient -Tx trace with NetMon and saw this
incredible inefficiency in the SMBs going on.

If restoring:

  d\e\f\g\h\i\j
  d\e\f\g\h\i\k
  d\e\f\g\h\i\l

etc,

then clitar calls check_path for each of these, which walks down the
directory path calling check path for:

  d, d\e, d\e\f, d\e\f\g, d\e\f\g\h, d\e\f\g\h\i

for each file to be restored.  ARRRGH.

I will have to put in a cache.

I also have a buffer overflow caught by safe_strcpy. Damn! More testing
required.



Regards
-------
Richard Sharpe, sharpe at ns.aus.com, NIC-Handle:RJS96
NS Computer Software and Services P/L, 
Ph: +61-8-8281-0063, FAX: +61-8-8250-2080, 
Samba (Team member), Linux, Apache, Digital UNIX, AIX, C, ...