2.0.4b: file structure leackage. Serious bug!

[Jeremy Allison]

Andy Bakun wrote:
> 
> Yeah, I uncovered the same problem when copying data off of my cdrom
> archive to a samba server.  I was provided with patches to help debug the
> problem, but I went out of town and have not had a chance to apply them and
> generate the debug logs asked of me.  I will get on it and produce the
> debug logs to speed up fixing this.  Sorry for the delay, everyone.
> 
> Andrej Borsenkow wrote:
> 
> >This is 2.0.4b + Win2k patch of Matt Chapman.
> >
> >Problem description: trying to extract large (~50M) Zip archive using
> WinZIP
> >(context explorer menu -> extract to), I got errors:
> >
> >[1999/06/21 17:55:43, 0] smbd/files.c:(85)
> >  ERROR! Out of file structures
> >
> >Analysing it, it looks the following problem:
> >
> >WinZIP tries to create directory structure for every extracted file. Every
> time
> >it does so, SAMBA allocates a file structure for every directory level
> created -
> >but never frees it at all. So, after WinZIP is through with
> >
> >\a\b\c\d\file
> >
> >SAMBA frees file structure for ``file'' but not structures for a,b,c,d.

So, does this mean that the client never sends the close
calls for the NT SMB directory opens ? Or is it a Samba
bug ?

More info would be good....

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------