libsmb/clientgen.c

[Luke Kenneth Casson Leighton]

there is a bug to fix in libsmb/clientgen.c cli_session_setup() it cannot
be used to send cleartext passwords to systems with user level security
set.

are there any objections to fixing this issue by moving the password
encryption routines outside of cli_session_setup() and then replacing the
two remaining call-sets (in client/client.c:do_connect()) and
smbwrapper/smbw.c to cli_session_setup(), cli_tcon_X() etc with calls to
cli_establish_connection()?

the only issue then is to maintain DEBUG output that
cline/client.c:do_connect() by getting cli_establish_connection() to
generate the same DEBUG output.

luke