runaway smbd in samba-2.0.1

Jeremy Allison jeremy at netcom.com
Sat Feb 6 21:59:48 GMT 1999


Can you try this quick patch to see if it's the while loops
around the waitpid calls that are causing the problem.

waitpid should only return < 0 on error according to my man 
pages - the only possibility is getting :

 ECHILD  if the process specified in pid does not exist or is not a child of the calling process.

Which shouldn't happen....

Regards,

	Jeremy Allison,
	Samba Team.


Index: lib/smbrun.c
===================================================================
RCS file: /data/cvs/samba/source/lib/smbrun.c,v
retrieving revision 1.5.2.5
diff -u -r1.5.2.5 smbrun.c
--- smbrun.c    1999/02/03 03:18:38     1.5.2.5
+++ smbrun.c    1999/02/06 21:55:58
@@ -134,6 +134,7 @@
                                errno = 0;
                                continue;
                        }
+                       break;
                }
                if (wpid != pid) {
                        DEBUG(2,("waitpid(%d) : %s\n",pid,strerror(errno)));
Index: smbd/chgpasswd.c
===================================================================
RCS file: /data/cvs/samba/source/smbd/chgpasswd.c,v
retrieving revision 1.41.2.8
diff -u -r1.41.2.8 chgpasswd.c
--- chgpasswd.c 1999/02/03 03:18:38     1.41.2.8
+++ chgpasswd.c 1999/02/06 21:56:05
@@ -323,6 +323,7 @@
         errno = 0;
         continue;
       }
+         break;
     }

     if (wpid < 0) {                                              




More information about the samba-technical mailing list