VxFS quotas (Was: Where to submit patches?)

[Dirk De Wachter]

Hello,

just to remind you all that HP-UX 10.20 seems to work perfectly with 
quotas on a VxFS file system and may not need any patches. Yet, 
depending on the OS installation a file 
/usr/include/sys/fs/vx_ioctl.h may exist (as does a file 
/usr/include/sys/fs/vx_bsdquota.h).

The patch submitted by David Lee, assumes that the VxFS should be 
handled different if this file exists, but I believe it may only do 
this based on both OS and the presence of this file. (I refer to the 
patched lines 673-678 of include/includes.h). Or perhaps, it should 
check the vx_quota.h file instead of vx_ioctl.h.
Several of the includes mentioned in the patch for smbd/quotas.c 
(lines 725 and up) are not present on HPUX systems and the patch may 
therefore break quotas on this OS.

I would suggest that not VXFS should be defined (as yet) in 
include/includes.h but VXFS_QUOTA to reflect that only quotas may be 
handled differently on VxFS and not other aspects of SAMBA. That is, 
VXFS may defined also, but should be used in a more general way, e.g. 
if also locking or syncing would be handled in a special way by 
SAMBA.


Sincerely,

Dirk De Wachter

*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*--*
Dirk De Wachter, MScEE, MScBME, PhD      mailto:Dirk.DeWachter at rug.ac.be
scientific researcher, systems administrator     http://navier.rug.ac.be
Hydraulics Laboratory, Ibitech, University of Gent  voice:+32 9 264 3281
Sint-Pietersnieuwstraat 41, B-9000 Gent Belgium     faxto:+32 9 264 3595
~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~--~