become_root remove patches (head)

Jeremy Allison jallison at
Wed Aug 18 16:13:53 GMT 1999

Michael Stockman wrote:
> Hello,
> Here are the patches that eliminates every call to become_root from
> samba (head). The function definition is not removed.
> They should be applied to locking/shmem_sysv.c locking/locking_slow.c
> rpc_server/srv_samr.c rpc_server/srv_netlog.c rpc_server/srv_pipe.c
> rpc_server/srv_lookup.c smbd/password.c smbd/dosmode.c
> smbd/chgpasswd.c.
> I haven't tried fixing any problems this might cause (please do that
> while I make some patches for the 2.0.X branch:-). I should have some
> time for that tonight.

Why are you wanting to remove become_root() from 2.0.x ?

This function is needed in many places to take on root
authority whilst doing something and then call unbecome_root()
to relinquish it again (eg. scanning the smbpasswd file).

What have you replaced this functionality with ?

become_root() got broken somewhat in HEAD due to some
careless changes in the authentication code. It works
correctly in 2.0.x as far as I know.


	Jeremy Allison,
	Samba Team.

Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba-technical mailing list