patch groupldap.c

[Luke Kenneth Casson Leighton]

On Fri, 6 Aug 1999, Ignacio Coupeau wrote:

> I posted a month ago a "possible" patch (and incorrect patch) for the
> groupldap.c:
> >         slprintf(filter, sizeof(pstring)-1,
> >                  "(&(member=%s,*)(objectclass=sambaGroup))", name);
> but this code is correct because "members" contains "name,rid,type". I
> know this now.
> 
> The problem is that in 
> http://samba.org/cgi-bin/cvsweb/samba/source/groupdb/groupldap.c.diff?only_with_tag=HEAD&r1=text&tr1=1.2&r2=1.3%3AHEAD&tr2=1.3&f=h
> I found an error: the version 1.2 I think is the correct and the 1.3 is
> wrong because 
> v 1.2 ...... "(&(cn=%s)(objectClass=sambaGroup))", name);
> v 1.3 ...... "(&(cn=%s,*)(objectClass=sambaGroup))", name); 
> 
> ...must get only a "cn" value without commas, so the version 1.2 looks
> fine.

this is line 225, yes?