CVS HEAD 1999-04-06 Compile Errors

[Paul]

On Wed, 7 Apr 1999, Florian Laws wrote:

> Configure-Options: --with-smbmount --with-syslog --with-quotas
> System: Debian GNU/Linux 2.2, glibc 2.1.1, Kernel 2.2.4-ac1
> 
> ----- cut here -----
> 
> Compiling printing/pcap.c
> Compiling printing/print_svid.c
> Compiling printing/printing.c
> printing/printing.c: In function `parse_lpq_bsd':
> printing/printing.c:266: `__ERROR__XX__NEVER_USE_STRCAT___' undeclared (first use in this function)
> printing/printing.c:266: (Each undeclared identifier is reported only once
> printing/printing.c:266: for each function it appears in.)
> printing/printing.c:266: parse error before `;'
> printing/printing.c:267: parse error before `;'
> printing/printing.c: In function `parse_lpq_lprng':
> printing/printing.c:381: `__ERROR__XX__NEVER_USE_STRCAT___' undeclared (first use in this function)
> printing/printing.c:381: parse error before `;'
> printing/printing.c:382: parse error before `;'
> make: *** [printing/printing.o] Error 1
> 
> ----- cut here -----
> 
> I'm somewhat puzzled, as __ERROR__XX__NEVER_USE_STRCAT___ is never referenced
> nor declared in the file. A quick grep throug all sources didn't find it
> anywhere.
> 
> Any help?
> 
> Thanks,
> 
> Florian

Hrm. This was fixed in the 2.0 branch but I guess is still in CVS.
printing.c uses strncat() and on glibc 2.1.X systems strncat() is a macro
that, amongst other things, uses strcat(). The solution is to change
instances of strncat() to safe_strcat().

Paul Laufer