nmbd dying...

[Jeremy Allison]

Luke Kenneth Casson Leighton wrote:

> 
> oh, come on!  i don't do that!  it breaks my coding standards. 

Yeah well the coding standards have a bug then :-).

Please - *no* multiline statements. They are a *nasty* bug
waiting to happen (IMHO).

> ...
> 
> those q += 4 lines are highly prevalent in ipc.c packet-parsing code.
> 

I know - and I'm splitting them into 2 lines wherever I find them.

> also, for "informational" purposes, i would recommend that
> allowableaccount is put back in, and printed out with a "DEBUG" statement.
> if we re-examine the code and find we need to add a feature which uses
> allowableaccount (whatever it is) then having this variable removed will
> make that job potentially difficult to understand.

True - time permitting I may add the code back in
bracketed with #ifdef 0's.

Cheers,

	Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------