trivial enhancement to samba tar (diffs relative to CVS tree)

Richard Sharpe sharpe at ns.aus.com
Sat Oct 3 01:55:33 GMT 1998


Hi Jay,

thanks for the patch ... It will go in this weekend. Sorry if I dropped
some stuff from your previous patch ...

At 02:20 PM 10/2/98 -0400, you wrote:
>
>Currently there's no way in smbclient's tar command to turn off
>tar_noisy except by saying tarmode quiet.  It is useful to be able to
>specify this on the commandline to smbclient (via the -T option) when
>smbclient is used non-interactively.  Here's a trivial patch that
>implements this.  This patch includes the three lines of code as well
>as updates to the help strings and manual page.  It is relative to the
>current CVS tree as of Friday, October 2, 1998 14:18 EDT (USA).  I
>hope you will consider its inclusion into the next release of samba.
>Please acknowledge this message.  Thanks!  While I was in the code, I
>took the liberty of fixing the help strings to accommodate my
>previously integrated patches to client.c and clitar.c to implement
>the ability to tar from a list of files.  I believe that was in my
>original patch, but it's not that important....
>
>--
>E. Jay Berkenbilt (ejb at ql.org)  |  http://www.ql.org/q/
>
>
>--- ./docs/smbclient.1.qdist	Fri Oct  2 13:45:25 1998
>+++ ./docs/smbclient.1	Fri Oct  2 14:10:25 1998
>@@ -402,6 +402,7 @@
> .BR X ,
> .BR b ,
> .BR g ,
>+.BR q ,
> .BR N
> or
> .BR a ;
>@@ -465,6 +466,10 @@
> only with the
> .B c
> flag.
>+
>+.B q
>+Quiet. Keeps tar from printing diagnostics as it works.  This is the
>+same as tarmode quiet.
> 
> .B N
> Newer than. Must be followed by the name of a file whose date is
>--- ./source/client/clitar.c.qdist	Fri Oct  2 13:45:42 1998
>+++ ./source/client/clitar.c	Fri Oct  2 14:09:09 1998
>@@ -2715,6 +2715,9 @@
>     case 'a':
>       tar_reset=True;
>       break;
>+    case 'q':
>+      tar_noisy=False;
>+      break;
>     case 'I':
>       if (tar_clipfl) {
> 	DEBUG(0,("Only one of I,X,F must be specified\n"));
>--- ./source/client/client.c.qdist	Fri Oct  2 13:45:40 1998
>+++ ./source/client/client.c	Fri Oct  2 14:15:27 1998
>@@ -3304,7 +3304,7 @@
>   {"exit",cli_send_logout,"logoff the server",{COMPL_NONE,COMPL_NONE}},
>   {"newer",cmd_newer,"<file> only mget files newer than the specified
local file",{COMPL_LOCAL,COMPL_NONE}},
>   {"archive",cmd_archive,"<level>\n0=ignore archive bit\n1=only get
archive files\n2=only get archive files and reset archive bit\n3=get all
files and reset archive bit",{COMPL_NONE,COMPL_NONE}},
>-  {"tar",cmd_tar,"tar <c|x>[IXbgNan] current directory to/from <file
name>",{COMPL_NONE,COMPL_NONE}},
>+  {"tar",cmd_tar,"tar <c|x>[IXFqbgNan] current directory to/from <file
name>",{COMPL_NONE,COMPL_NONE}},
>   {"blocksize",cmd_block,"blocksize <number> (default
20)",{COMPL_NONE,COMPL_NONE}},
>   {"tarmode",cmd_tarmode,
>      "<full|inc|reset|noreset> tar's behaviour towards archive
bits",{COMPL_NONE,COMPL_NONE}},
>@@ -3740,7 +3740,7 @@
>   DEBUG(0,("\t-W workgroup          set the workgroup name\n"));
>   DEBUG(0,("\t-c command string     execute semicolon separated
commands\n"));
>   DEBUG(0,("\t-t terminal code      terminal i/o code
{sjis|euc|jis7|jis8|junet|hex}\n"));
>-  DEBUG(0,("\t-T<c|x>IXgbNan        command line tar\n"));
>+  DEBUG(0,("\t-T<c|x>IXFqgbNan      command line tar\n"));
>   DEBUG(0,("\t-D directory          start from directory\n"));
>   DEBUG(0,("\n"));
> }
>
>
>

Regards
-------
Richard Sharpe, sharpe at ns.aus.com, NIC-Handle:RJS96
NS Computer Software and Services P/L, 
Ph: +61-8-8281-0063, FAX: +61-8-8250-2080, 
Samba, Linux, Apache, Digital UNIX, AIX, Netscape, Stronghold, C, ...


More information about the samba-technical mailing list