clientgen.c error messages: dos / nt status (8, 32 bit)

Luke Kenneth Casson Leighton lkcl at switchboard.net
Fri Oct 2 19:48:04 GMT 1998


32 bit error messages in the current cvs tree are being dealt with
incorrectly.  a "warning" - 0x8000nnnn is _not_ an error.  the following
test is therefore wrong:

if (CVAL(cli->inbuf, smb_rcls) != 0)
{
	return False;
}

BRANCH_NTDOM code has a function called "cli_error()" which checks for 32
bit, and is called in all locations where errors require to be checked: no
reference to smb_rcls is used.

i will be replacing the above line in the cli_api_pipe() - actually
cli_receive_trans() - and any locations needed to get the dce/rpc client
code working with cli_error() calls: it is stopping rpcclient from being
able to deal with over-side dce/rpc packets (that span multiple SMBreadX
calls).

luke



More information about the samba-technical mailing list