safe_strcpy

[Luke Kenneth Casson Leighton]

On Fri, 22 May 1998, Jeremy Allison wrote:

> Luke Kenneth Casson Leighton wrote:
> > 
> > if the string length is _exactly_ the length of the buffer, is it
> > deliberately non-null-terminated?
> 
> safe_strcpy never leaves a string non-null
> terminated.
> 
> If the string length is exactly the length
> of the buffer then it's an overflow by one
> (because of the expected null).
> 
> Always pass buffer_len-1

??? -1????

damn, that's counter-intuitive.

 to the safe_xxx 
> routines (look at the fstrcpy and pstrcpy
> defines in smb.h).
> 
> Jeremy.
> 
> -- 
> --------------------------------------------------------
> Buying an operating system without source is like buying
> a self-assembly Space Shuttle with no instructions.
> --------------------------------------------------------
>