password API needed

[Luke Kenneth Casson Leighton]

On Wed, 20 May 1998, Jeremy Allison wrote:

> Edan Idzerda wrote:
> > 
> > >From linux/fs/smbfs/inode.c:
> > 
> >     static struct super_operations smb_sops =
> >     {
> >             smb_read_inode,         /* read inode */
> >             NULL,                   /* write inode */
> >             smb_put_inode,          /* put inode */
> >             smb_delete_inode,       /* delete inode */
> >             smb_notify_change,      /* notify change */
> >             smb_put_super,          /* put superblock */
> >             NULL,                   /* write superblock */
> >             smb_statfs,             /* stat filesystem */
> >             NULL                    /* remount filesystem */
> >     };
> > 
> > I believe that a NULL function pointer in Linux's VFS layer means
> > "give me default behavior."  Solaris on the other hand uses
> > actual dummy functions like fs_nosys or fs_sync to do this.
> > For as many of the things that Linux does right, maybe this is not
> > one of them :)
> > 
> 
> Well it's a matter of taste to me. I hate having NULL entries
> in function tables as they can mean 'give me default behaviour'
> or 'oh dear I forgot to initialize this' :-).
> 
> I prefer insisting on entries being present - even if it only
> points to a stub function that prints "not implemented" :-).

all the "stubs" now call the conversion routines.

> But what Luke did was worse than just giving default behavior,
> he was also calling a bunch of conversion functions so password
> db writers "didn't have to worry about implementing that stuff".

well... i put "you can do both, or you can do either, but not neither, and
the minimum recommended to new api writers is sam_passwd functions".
 
> Putting that into the vector indirection code was anathema to
> me (which is why I'm getting him to change it)

done!