nmbd packet queue

Luke Kenneth Casson Leighton lkcl at switchboard.net
Fri Aug 28 14:45:28 GMT 1998


tridge,

the packet queue code in samba is completely redundant.  remember, it
dates back to 1.9.15 when samba didn't have the state machine in it:

send_nmb_query( ..., nmb_sequence_no);

while (receive_packet())
{
	if (received_packet.nmb_sequence_no == nmb_sequence_no)
	{
		queue_packet(received_packet);
	}
	else
	{
		process_packet(received_packet);
		break;
	}
}

so, while waiting for a _specific_ response, all other packets got queued,
then taken off the queue and dealt with.  unfortunately, if there was no
response to the query, you're stuffed.

this code, i believe, has been redundant since the introduction of the
nmbd state machine in 1.9.16.



More information about the samba-technical mailing list