fnum chaining and pipes

[Luke Kenneth Casson Leighton]

On Mon, 17 Aug 1998, Andrew Tridgell wrote:

> > > While converting the code to get rid of fnum I noticed that the IPC
> > > pipes code doesn't seem to handle fnum chaining. This is where a
> > > client does a OpenX+ReadX chain (or some other combination like
> > > ReadX+Close) and the fnum from the first operation is supposed to be
> > > used for the second.
> > 
> > i copied the code from the File[] stuff.  presumably incorrectly?
> 
> You copied, for example, GETFNUM() to make GETPNUM(). You even copied
> the comment like this:
> 
> /* this macro should always be used to extract an pnum (smb_fid) from
>    a packet to ensure chaining works correctly */
> #define GETPNUM(buf,where) (chain_pnum!= -1?chain_pnum:SVAL(buf,where))
> 
> then you never used GETPNUM() so chaining has no chance of working.

oh well.  it never occurs, so what the heck.