Wrong KOI8 --> 866 convertation (Bug report)

[Jeremy Allison]

"A.V.Shutko" wrote:
> 
> OS            :      FreeBSD 3.3-RELEASE #1: Tue Feb 22 19:12:08 VLAT 2000
> Compiler      :      gcc version 2.7.2.3
> CVS-Branch    :      SAMBA_TNG
> Version/Date  :      2.5.3 / 03.05.00 9:10
> Error Type    :      reproduceable
> Short Desc.   :      Wrong KOI8 --> 866 convertation
> Trigger       :      If i rename file.txt on network drive to Russian
>                      it  disappears  (but I can view it on Unix disk -
>                      its  name  in KOI8). All files in Russian are not
>                      showing on smb shares.
> 
> Fix           :      This  is  because  of dual filename encoding in
>                      /smbd/vfs.c
> 
> //------------------------------------------------------------------------
>         {
>                 static pstring buf;
>                 memcpy(buf, dname, NAMLEN(ptr)+1);
> THIS******      unix_to_dos(buf, True);
>                 dname = buf;
>         }
> 
> AND THIS*****   unix_to_dos(dname, True);  // I removed this and all
>                                               work fine.
> 
>         return(dname);
> }

Thanks for that fix - I've added it to TNG and HEAD.

Cheers,

	Jeremy Allison,
	Samba Team.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------