patch (fwd)

Michael Breuer mbreuer at siac.com
Tue Mar 14 16:53:19 GMT 2000


Ok... consider me an autoconf newbie.  In this particular case, IRIX requires that <standards.h> be included before <netinet/*.h>.
The "patch" I created seemed reasonable to me... if configure is running on IRIX and standards.h exists then source it in.  I'm not
sure how creating a new macro is warranted here, and this patch should only be invoked on IRIX.

That said, could you suggest an alternative which would not break other implementations?

Thanks,

Michael Breuer
mbreuer at siac.com

nazard at dragoninc.on.ca wrote:

> On 14 Mar, Luke Kenneth Casson Leighton wrote:
> > hi, pleases could people review and try out this patch and let me know if
> > it breaks your system or not.  the last patch of this type (for irix) i
> > applied it broke aix, redhat linux and a few others.
>
> > *** samba-tng-alpha.0.14/source/configure.in  Fri Mar 10 15:02:14 2000
> > --- samba-tng-alpha.0.14.IRIX.PATCH/source/configure.in       Mon Mar 13 09:05:51 2000
> > ***************
> > *** 79,84 ****
> > --- 79,94 ----
> >       *aix4*)
> >         CPPFLAGS="$CPPFLAGS -D_LARGE_FILES"
> >         ;;
> > + #
> > + # Irix needs standards.h to detect netinet
> > + #
> > +     *irix*)
> > +     AC_CHECK_HEADERS(standards.h,
> > +             cat >> confdefs.h <<EOF
> > + #include <standards.h>
> > + EOF
> > + )
> > +       ;;
> >   esac
> >
> >   AC_INLINE
>
> This has the same problem as last time AFAICS. The problem was that
> AC_CHECK_HEADERS adds some special code the FIRST time it is outputed
> to detect how to call the pre-processor. The way I fixed it when this
> first happened was to add an explicit check for the pre-processor.
>
> Index: configure.in
> ===================================================================
> RCS file: /cvsroot/samba/source/configure.in,v
> retrieving revision 1.102.2.19
> diff -u -w -r1.102.2.19 configure.in
> --- configure.in        2000/03/10 19:53:25     1.102.2.19
> +++ configure.in        2000/03/14 07:40:48
> @@ -34,6 +34,7 @@
>
>  dnl Checks for programs.
>  AC_PROG_CC
> +AC_PROG_CPP
>  AC_PROG_INSTALL
>  AC_PROG_AWK
>
>
> --
> Doug Nazar
> Dragon Computer Consultants Inc.
> Tel: (416) 708-1578     Fax: (416) 708-8081



More information about the samba-ntdom mailing list