Problem with sid_to_string in CVS Samba-TNG

[Paul J Collins]

Just decided to play with CVS and Samba (checked it out at around
15:30 GMT), and my new installation is creating stringified SIDs like
this: (from log.samr)

get_sam_domain_name: PDC/BDC MELOCHORD
read_sid: Domain: MELOCHORD
sid_to_string returning S--1989380350-3784617370-2315756573
read_sid_from_file /usr/local/samba-tng/private/MELOCHORD.SID: sid S--1989380350-3784617370-2315756573
get_member_domain_sid: sid_to_string returning S--1989380350-3784617370-2315756573
S--1989380350-3784617370-2315756573
sid_to_string returning S--32
Map:	Domain:	BUILTIN	SID:	S--32
sid_to_string returning S-
Map:	Domain:	Global Domain	SID:	S-
sid_to_string returning S--0
Map:	Domain:	Everyone	SID:	S--0
sid_to_string returning S--0
Map:	Domain:	LOCAL	SID:	S--0
sid_to_string returning S--0
Map:	Domain:	Creator Owner	SID:	S--0
sid_to_string returning S--1
Map:	Domain:	Creator Group	SID:	S--1
sid_to_string returning S--2
Map:	Domain:	Creator Server Owner	SID:	S--2
sid_to_string returning S--3
Map:	Domain:	Creator Server Group	SID:	S--3
sid_to_string returning S-
Map:	Domain:	NT Authority	SID:	S-
sid_to_string returning S--1

And so on.

I checked the code for sid_to_string (CVS versus 2.4.2), and bar the
change from fstring to pstring, it looks the same.  The revision
number is missing from *somewhere*...

Paul.

-- 
Paul Collins <sneakums at eircom.net> - - - - - [ A&P,a&f ]
 GPG: 0A49 49A9 2932 0EE5 89B2  9EE0 3B65 7154 8131 1BCD
 PGP: 88BA 2393 8E3C CECF E43A  44B4 0766 DD71 04E5 962C
"Linux: it's just this operating system, you know?"