Guest account - NO PASSWORD in NT-password field

[Lutz Jacob]

Jens Beyer wrote:

>Everything runs fine except when somebody tries to login - the
>attached smd process runs at 100% cpu and ist locked while processing
>smbpasswd, namely the guest entry wich has
>
>pcguest:65533:NO PASSWORDXXXXXXXXXXXXXXXXXXXXX:NO
PASSWORDXXXXXXXXXXXXXXXXXXXXX:[U          ]:LCT-36ED09B1:
>
>this fails in 'strhex_to_str (lib/util_str.c)' while processing "NO
PASSWORD"
>in the NT password field. Replacing it with



There is some bad code in strhex_to_str:

 while (!(p1 = strchr(hexchars, toupper(strhex[i]))))
 {
    continue;
 }

This is an endless loop if the call to strchr() fails and gives NULL. Same
code also exists in 2.0.3.

Lutz