Patch for parse_samr.c:make_sam_info_1

Luke Kenneth Casson Leighton lkcl at
Mon Jan 11 13:57:15 GMT 1999

On Sun, 10 Jan 1999, Sean Mathews wrote:

>  This fixes problems with the SAMR_QUERY_DISPINFO command
> from a client where it is attempting to enum the users
> if your smbpasswd file is not in perfect order say you have users
> and MACHINE$ accounts mixed it gets to be a real mess and since
> its not documented that it is necessarey to have this and i myself

none of it is... yet.  i'm just doing samr.

> and too stupid to read any doc's in detail enough to find this out
> before doing samba work might be a good idea to make the code
> more umm idiot proof.

hey, you have a point here!

> 	/* Actual start_idx needs to be based upon the acb_mask 
> 	   so we will sync i to the needed starting point in pass[] */
> 	for (i = 0, x = 0; i < num_sam_entries; i++)
> 	{
> 		if (IS_BITS_SET_ALL(pass[i].acb_info, acb_mask))
> 		{			
> 			if(x == start_idx)
> 				break;
> 			x++;
> 		}
> 	}

this is the bit you added, right?

More information about the samba-ntdom mailing list