errors compiling under DU4.0D

[Luke Kenneth Casson Leighton]

On Thu, 21 May 1998, Tim Winders wrote:

> I just downloaded the CVS source (12:00AM CST, 5/21/98) and received these
> errors during compile: (under Digital Unix 4.0D)
> 
> cc: Warning: lib/rpc/server/srv_samr.c, line 110: In this statement, &
> before array "(r_u.pol.data)" is ignored.
>         bzero(&(r_u.pol.data), POL_HND_SIZE);
> --------^
> cc: Warning: lib/rpc/server/srv_samr.c, line 798: In this statement, &
> before array "(r_u.user_pol.data)" is ignored.
>         bzero(&(r_u.user_pol.data), POL_HND_SIZE);
> --------^
> cc: Warning: lib/rpc/server/srv_samr.c, line 1108: In this statement, &
> before array "(r_u.pol.data)" is ignored.
>         bzero(&(r_u.pol.data), POL_HND_SIZE);
> --------^

done.
 
> 
> Compiling passdb.c
> cc: Warning: passdb.c, line 814: In this statement, & before array "fline"
> is ignored.
>   if(read(fd, &fline, sizeof(fline) -1 ) < 0) {
> --------------^

done.
 
> 
> cc: Warning: smbpass.c, line 256: In this statement, the referenced type
> of the pointer value "p" is "unsigned char", which is not compatible with
> "signed char"
> .
>       pw_buf.acct_ctrl = pdb_decode_acct_ctrl(p);
> -------------------------^

your compiler is lying to you: the function returns "uint16"; acct_ctrl is
also a uint16.


> cc: Warning: smbpass.c, line 478: In this statement, the referenced type
> of the pointer value "(char ...)malloc(...)" is "signed char", which is
> not compatible with "unsigned char".
>   if((new_entry = (char *)malloc( new_entry_length )) == NULL) {
> ------^

done.

> Everything seems to run OK, so I don't know if I should ignore these
> errors

ignore them.

> or what exactly they mean...

that's why i fixed them for you.  thanks tim