[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Tue Sep 1 11:25:02 UTC 2026


The branch, master has been updated
       via  43ad97b33ba ctdb-common: Fix CID 1700569: Memory - corruptions (OVERRUN)
      from  f7ba52c006d s3-script: add additional s4u2self samlogon test

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 43ad97b33ba3592ae4b560f357c996799e22e200
Author: Martin Schwenke <mschwenke at ddn.com>
Date:   Sat Aug 29 21:33:39 2026 +1000

    ctdb-common: Fix CID 1700569: Memory - corruptions (OVERRUN)
    
    Not actually an overrun because we've allocated a samba_sockaddr, so
    we're not overrunning the alocated buffer.  However, we really have to
    make this relative to samba_sockaddr's sockaddr_storage rather than
    sockaddr_ll to keep Coverity happy.
    
    This was previously fixed by commit
    bd0b91b72fd54d32d3f5f8d73128cbab41736d49 but reintroduced by commit
    e8924635c7d77a64f638222698bc63fc67638ade with the change to struct
    samba_sockaddr.
    
    Volker, you were right!  Sorry...
    
    Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
    Reviewed-by: Anoop C S <anoopcs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Tue Sep  1 11:24:03 UTC 2026 on atb-devel-224

-----------------------------------------------------------------------

Summary of changes:
 ctdb/common/system_socket.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/common/system_socket.c b/ctdb/common/system_socket.c
index 3b81c85f485..ce9d7edbd68 100644
--- a/ctdb/common/system_socket.c
+++ b/ctdb/common/system_socket.c
@@ -546,8 +546,8 @@ static int ip6_ll_multicast_build(struct sockaddr_ll *in,
 	uint8_t *in_sll_addr = (uint8_t *)in + offsetof(struct sockaddr_ll,
 							sll_addr);
 	struct sockaddr_ll *out_ll = &out->u.ll;
-	uint8_t *out_sll_addr = (uint8_t *)out_ll + offsetof(struct sockaddr_ll,
-							     sll_addr);
+	uint8_t *out_sll_addr =
+		(uint8_t *)&out->u.ss + offsetof(struct sockaddr_ll, sll_addr);
 
 	*out_ll = (struct sockaddr_ll) {
 		.sll_family = AF_PACKET,


-- 
Samba Shared Repository



More information about the samba-cvs mailing list