[SCM] Samba Shared Repository - branch master updated

[Günther Deschner]

The branch, master has been updated
       via  5200c120f34 vfs_ceph_new: Use integer value instead of boolean
       via  82c0988a8bc vfs_ceph_new: dont use ceph_ll_nonblocking_readv_writev for fsync_send
      from  821cf798d87 Fix crash in DLZ plugin for incorrect setup

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 5200c120f34c4a28fa9f4cb55b46dbb9d90eb758
Author: Anoop C S <anoopcs at samba.org>
Date:   Mon Sep 22 11:11:46 2025 +0530

    vfs_ceph_new: Use integer value instead of boolean
    
    ceph_ll_fsync() API[1] accepts the third and final argument as integer
    and not a boolean value.
    
    [1] https://github.com/ceph/ceph/blob/main/src/include/cephfs/libcephfs.h#L2041
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15919
    
    Signed-off-by: Anoop C S <anoopcs at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Mon Sep 22 12:24:35 UTC 2025 on atb-devel-224

commit 82c0988a8bc3d3e364e2d56ad8ea27e359fbc3f0
Author: Shachar Sharon <ssharon at redhat.com>
Date:   Wed Sep 17 14:25:27 2025 +0300

    vfs_ceph_new: dont use ceph_ll_nonblocking_readv_writev for fsync_send
    
    Commit 4ae922413844 ("vfs_ceph_new: use libcephfs nonblocking API for
    async-io ops") uses ceph_ll_nonblocking_readv_writev for fsync_send.
    However, the actual behaviour of libcephfs when using this API with
    'fsync=true' is not async-fsync, as one may assume. Instead,
    vfs_ceph_new should use a nonblocking fsync API[1], once it is ready.
    
    Removed the usage of ceph_ll_nonblocking_readv_writev for fsync.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=15919
    
    [1] https://github.com/ceph/ceph/commit/c88a21c30d8b265adb152f631d2629d29539f7b7
    
    Signed-off-by: Shachar Sharon <ssharon at redhat.com>
    Reviewed-by: Anoop C S <anoopcs at samba.org>
    Reviewed-by: Xavi Hernandez <xhernandez at redhat.com>
    Reviewed-by: Guenther Deschner <gd at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source3/modules/vfs_ceph_new.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_ceph_new.c b/source3/modules/vfs_ceph_new.c
index 7112719a399..c71adcc5678 100644
--- a/source3/modules/vfs_ceph_new.c
+++ b/source3/modules/vfs_ceph_new.c
@@ -3018,18 +3018,8 @@ static struct tevent_req *vfs_ceph_fsync_send(struct vfs_handle_struct *handle,
 	SMBPROFILE_BYTES_ASYNC_SET_IDLE_X(state->profile_bytes,
 					  state->profile_bytes_x);
 
-#if HAVE_CEPH_ASYNCIO
-	state->req = req;
-	state->data = NULL;
-	state->len = 0;
-	state->off = 0;
-	state->fsync = true;
-	vfs_ceph_aio_submit(handle, req, ev);
-	return req;
-#endif
-
 	vfs_ceph_aio_start(state);
-	ret = vfs_ceph_ll_fsync(handle, state->cfh, false);
+	ret = vfs_ceph_ll_fsync(handle, state->cfh, 0);
 	vfs_ceph_aio_finish(state, ret);
 	if (ret != 0) {
 		/* ceph_fsync returns -errno on error. */


-- 
Samba Shared Repository