[SCM] Samba Shared Repository - branch v4-23-test updated
Jule Anger
janger at samba.org
Fri Sep 5 09:21:01 UTC 2025
The branch, v4-23-test has been updated
via 968b453b8d5 s3:net: fix "net ads group"
via e4581ccfe7b krb5: handle GSS-Proxy credentials lifetime
from 48ea6b39878 VERSION: Bump version up to Samba 4.23.0rc4...
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-23-test
- Log -----------------------------------------------------------------
commit 968b453b8d567f005c2f1c451c3f2853007e0c13
Author: MikeLiu <mikeliu at qnap.com>
Date: Fri Aug 29 17:31:36 2025 +0800
s3:net: fix "net ads group"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15900
Signed-off-by: MikeLiu <mikeliu at qnap.com>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Noel Power <npower at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Sep 4 09:33:27 UTC 2025 on atb-devel-224
(cherry picked from commit 8738fa1cc42d913e3ab2b54fe1e75ca4da37073f)
Autobuild-User(v4-23-test): Jule Anger <janger at samba.org>
Autobuild-Date(v4-23-test): Fri Sep 5 09:20:08 UTC 2025 on atb-devel-224
commit e4581ccfe7b11c5f884d3757b393bf1e26a49d4b
Author: Alexander Bokovoy <ab at samba.org>
Date: Tue Sep 2 10:36:11 2025 +0300
krb5: handle GSS-Proxy credentials lifetime
GSS-Proxy stores its credential in encrypted form in the Kerberos ccache
with a start and end time of 0 and a server principal in the realm named
'X-GSSPROXY:'. This credential is accessed through GSS-Proxy interposer
mechanism in MIT Kerberos and cannot be analysed with raw krb5 API.
As MIT Kerberos has no krb5_cc_get_lifetime() implementation, add check
for the GSS-Proxy credential to smb_krb5_cc_get_lifetime() wrapper to
return KRB5_PLUGIN_NO_HANDLE. The two places where
smb_krb5_cc_get_lifetime() is used then handle this return code to avoid
deciding on the 'expired' lifetime to cause a kinit.
This fixes FreeIPA use case where an IPA API endpoint uses Samba Python
bindings with a GSS-Proxy-controlled credential cache.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=15902
Signed-off-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky at samba.org>
Autobuild-User(master): Pavel Filipensky <pfilipensky at samba.org>
Autobuild-Date(master): Wed Sep 3 10:15:50 UTC 2025 on atb-devel-224
(cherry picked from commit c00b98ad840706cda222bb610d0d4860b98c72d4)
-----------------------------------------------------------------------
Summary of changes:
auth/credentials/credentials_krb5.c | 36 ++++++++++++++++++++++++++----------
lib/krb5_wrap/krb5_samba.c | 35 +++++++++++++++++++++++++++++++++--
source3/utils/net_ads.c | 2 +-
3 files changed, 60 insertions(+), 13 deletions(-)
Changeset truncated at 500 lines:
diff --git a/auth/credentials/credentials_krb5.c b/auth/credentials/credentials_krb5.c
index 4dc7e7be67e..8d289e26781 100644
--- a/auth/credentials/credentials_krb5.c
+++ b/auth/credentials/credentials_krb5.c
@@ -687,7 +687,14 @@ _PUBLIC_ int cli_credentials_get_named_ccache(struct cli_credentials *cred,
bool kinit_required = false;
ret = smb_krb5_cc_get_lifetime(cred->ccache->smb_krb5_context->krb5_context,
cred->ccache->ccache, &lifetime);
- if (ret == KRB5_CC_END || ret == ENOENT) {
+ if (ret == KRB5_PLUGIN_NO_HANDLE) {
+ /*
+ * KRB5_PLUGIN_NO_HANDLE is a special case of the encrypted
+ * GSSProxy credential. We don't know its lifetime but assume it
+ * is a valid one. Acquiring it will show the lifetime.
+ */
+ kinit_required = false;
+ } else if (ret == KRB5_CC_END || ret == ENOENT) {
kinit_required = true;
} else if (ret == 0) {
if (lifetime == 0) {
@@ -800,18 +807,27 @@ _PUBLIC_ bool cli_credentials_get_ccache_name_obtained(
if (ret == KRB5_CC_END || ret == ENOENT) {
return false;
}
- if (ret != 0) {
+
+ /*
+ * KRB5_PLUGIN_NO_HANDLE is a special case of the encrypted
+ * GSSProxy credential. We don't know its lifetime but assume it
+ * is a valid one. Acquiring it will show the lifetime.
+ * */
+ if (ret != 0 && ret != KRB5_PLUGIN_NO_HANDLE) {
return false;
}
- if (lifetime == 0) {
- return false;
- } else if (lifetime < 300) {
- if (cred->password_obtained >= cred->ccache_obtained) {
- /*
- * we have a password to re-kinit
- * so let the caller try that.
- */
+
+ if (ret == 0) {
+ if (lifetime == 0) {
return false;
+ } else if (lifetime < 300) {
+ if (cred->password_obtained >= cred->ccache_obtained) {
+ /*
+ * we have a password to re-kinit
+ * so let the caller try that.
+ */
+ return false;
+ }
}
}
diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c
index f9d91a4f0c1..dcf91348d1a 100644
--- a/lib/krb5_wrap/krb5_samba.c
+++ b/lib/krb5_wrap/krb5_samba.c
@@ -3025,6 +3025,8 @@ krb5_error_code smb_krb5_cc_get_lifetime(krb5_context context,
krb5_creds cred;
krb5_timestamp endtime = 0;
krb5_timestamp now;
+ char *realm = NULL;
+ TALLOC_CTX *mem_ctx = NULL;
*t = 0;
@@ -3038,12 +3040,37 @@ krb5_error_code smb_krb5_cc_get_lifetime(krb5_context context,
return kerr;
}
+ mem_ctx = talloc_stackframe();
+ if (mem_ctx == NULL) {
+ krb5_cc_end_seq_get(context, id, &cursor);
+ return ENOMEM;
+ }
+
while ((kerr = krb5_cc_next_cred(context, id, &cursor, &cred)) == 0) {
if (krb5_is_config_principal(context, cred.server)) {
krb5_free_cred_contents(context, &cred);
continue;
}
+ realm = smb_krb5_principal_get_realm(mem_ctx, context, cred.server);
+ if (realm == NULL) {
+ krb5_free_cred_contents(context, &cred);
+ kerr = ENOMEM;
+ break;
+ }
+
+ /*
+ * 'X-GSSPROXY:' is the realm for an encrypted credential stored
+ * by the GSSProxy. There are no other creds in such ccache and
+ * we cannot see the actual lifetime (it is set to 0),
+ * indicate to the caller they need to handle this themselves.
+ */
+ if (strcmp(realm, "X-GSSPROXY:") == 0) {
+ krb5_free_cred_contents(context, &cred);
+ kerr = KRB5_PLUGIN_NO_HANDLE;
+ break;
+ }
+
#ifndef HAVE_FLAGS_IN_KRB5_CREDS
if (cred.ticket_flags & TKT_FLG_INITIAL) {
#else
@@ -3073,13 +3100,17 @@ krb5_error_code smb_krb5_cc_get_lifetime(krb5_context context,
krb5_free_cred_contents(context, &cred);
}
+ krb5_cc_end_seq_get(context, id, &cursor);
+ talloc_free(mem_ctx);
+ if (kerr == ENOMEM || kerr == KRB5_PLUGIN_NO_HANDLE) {
+ return kerr;
+ }
+
if (now < endtime) {
*t = (time_t) (endtime - now);
kerr = 0;
}
- krb5_cc_end_seq_get(context, id, &cursor);
-
return kerr;
}
#endif /* HAVE_KRB5_CC_GET_LIFETIME */
diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index f77c2b8210a..6c11faeb091 100644
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -1360,7 +1360,7 @@ int net_ads_group(struct net_context *c, int argc, const char **argv)
char *disp_fields[2] = {NULL, NULL};
int ret = -1;
- if (argc >= 0) {
+ if (argc > 0) {
TALLOC_FREE(tmp_ctx);
return net_run_function(c, argc, argv, "net ads group", func);
}
--
Samba Shared Repository
More information about the samba-cvs
mailing list