[SCM] Samba Shared Repository - branch master updated

[Anoop C S]

The branch, master has been updated
       via  8e8848280af lib:util: Fix resourse leak CID#1412633
      from  b1e44875210 s3-vfs_fruit: add 'fruit:veto_localized' option

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 8e8848280af4be107fc3548d355955b25ff2b7a1
Author: Vinit Agnihotri <vagnihot at redhat.com>
Date:   Thu Aug 14 16:04:17 2025 +0530

    lib:util: Fix resourse leak CID#1412633
    
    Stop using un-needed variable 'handle', this variable is not used
    anywhere later.
    Also load_module() internally allocates and uses handle, which suffice
    for its operation.
    
    This fixes resource leak issue reported by coverity #1412633
    
    Signed-off-by: Vinit Agnihotri <vagnihot at redhat.com>
    Reviewed-by: Anoop C S <anoopcs at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Anoop C S <anoopcs at samba.org>
    Autobuild-Date(master): Fri Aug 15 06:19:51 UTC 2025 on atb-devel-224

-----------------------------------------------------------------------

Summary of changes:
 lib/util/modules.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/util/modules.c b/lib/util/modules.c
index 4260234b007..cafc73d6259 100644
--- a/lib/util/modules.c
+++ b/lib/util/modules.c
@@ -151,7 +151,6 @@ init_module_fn *load_samba_modules(TALLOC_CTX *mem_ctx, const char *subsystem)
 static NTSTATUS load_module_absolute_path(const char *module_path,
 					  bool is_probe)
 {
-	void *handle;
 	init_module_fn init;
 	NTSTATUS status;
 
@@ -159,7 +158,7 @@ static NTSTATUS load_module_absolute_path(const char *module_path,
 		 is_probe ? "Probing" : "Loading",
 		 module_path);
 
-	init = load_module(module_path, is_probe, &handle);
+	init = load_module(module_path, is_probe, NULL);
 	if (init == NULL) {
 		return NT_STATUS_UNSUCCESSFUL;
 	}
@@ -171,7 +170,6 @@ static NTSTATUS load_module_absolute_path(const char *module_path,
 		DBG_ERR("Module '%s' initialization failed: %s\n",
 			module_path,
 			get_friendly_nt_error_msg(status));
-		dlclose(handle);
 		return status;
 	}
 


-- 
Samba Shared Repository