[SCM] Samba Shared Repository - branch v4-21-test updated

[Jule Anger]

The branch, v4-21-test has been updated
       via  eed4dfe3a47 libcli/smb: Fix failure of Smb3UnixTests.test_create_context_reparse
      from  d7f49d90b2f VERSION: Bump version up to Samba 4.21.0rc5...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-21-test


- Log -----------------------------------------------------------------
commit eed4dfe3a47f5fd089cf1846e5c69bc0e56187a5
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 28 16:19:27 2024 +0100

    libcli/smb: Fix failure of Smb3UnixTests.test_create_context_reparse
    
    On tumbleweed at least the definition in py_reparse_put of 'reserved' as
    'unsigned' causes the tag value to be overwritten. Note: ParseTuple is
    given a format of 'Kk' where
      K = unsigned long long (for tag)
      k = unsigned long      (for reserved)
    
    The problem is 'reserved' is defined as 'unsigned' which on a
    64 bit linux system has size 4. The size however of the 'unsigned long' type
    on the same 64 bit system is 8. This causes 'tag' to be overwritten by
    the value of 'reserved' because it's destination size is smaller than
    expected.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15702
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Wed Aug 28 18:38:01 UTC 2024 on atb-devel-224
    
    Autobuild-User(v4-21-test): Jule Anger <janger at samba.org>
    Autobuild-Date(v4-21-test): Thu Aug 29 13:10:29 UTC 2024 on atb-devel-224

-----------------------------------------------------------------------

Summary of changes:
 libcli/smb/py_reparse_symlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/libcli/smb/py_reparse_symlink.c b/libcli/smb/py_reparse_symlink.c
index d28a8fd8b93..5e2e961ef01 100644
--- a/libcli/smb/py_reparse_symlink.c
+++ b/libcli/smb/py_reparse_symlink.c
@@ -30,7 +30,7 @@ static PyObject *py_reparse_put(PyObject *module, PyObject *args)
 	char *reparse = NULL;
 	Py_ssize_t reparse_len;
 	unsigned long long tag = 0;
-	unsigned reserved = 0;
+	unsigned long reserved = 0;
 	uint8_t *buf = NULL;
 	ssize_t buflen;
 	PyObject *result = NULL;


-- 
Samba Shared Repository