[SCM] Samba Shared Repository - branch master updated

Martin Schwenke martins at samba.org
Thu Sep 21 00:47:01 UTC 2023


The branch, master has been updated
       via  8b9f464420b ctdb-daemon: Call setproctitle_init()
      from  3481bbfede5 smbd: Fix BZ15481

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 8b9f464420b66cebaf00654cf8b19165b301b8b6
Author: Martin Schwenke <mschwenke at ddn.com>
Date:   Tue Sep 19 17:47:36 2023 +1000

    ctdb-daemon: Call setproctitle_init()
    
    Commit 19c82c19c009eefe975ae95c8b709fc93f5f4c39 changed the behaviour
    of prctl_set_comment() so it now calls setproctitle(3bsd) by default.
    
    In some Linux distributions (e.g. Rocky Linux 8.8), this results in
    messages like this spamming the logs:
    
      ctdbd: setproctitle not initialized, please either call setproctitle_init() or link against libbsd-ctor.
    
    Most Samba daemons seem to call setproctitle_init(), so do it here.
    
    In the longer term CTDB should also switch to using lib/util's
    process_set_title(), like the rest of Samba, for more flexible process
    names.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15479
    
    Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Thu Sep 21 00:46:50 UTC 2023 on atb-devel-224

-----------------------------------------------------------------------

Summary of changes:
 ctdb/server/ctdbd.c | 2 ++
 1 file changed, 2 insertions(+)


Changeset truncated at 500 lines:

diff --git a/ctdb/server/ctdbd.c b/ctdb/server/ctdbd.c
index 10541cb21f1..a388bff1598 100644
--- a/ctdb/server/ctdbd.c
+++ b/ctdb/server/ctdbd.c
@@ -170,6 +170,8 @@ int main(int argc, const char *argv[])
 	const char *test_mode;
 	bool ok;
 
+	setproctitle_init(argc, discard_const(argv), environ);
+
 	/*
 	 * Basic setup
 	 */


-- 
Samba Shared Repository



More information about the samba-cvs mailing list