[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Wed Jun 28 07:03:01 UTC 2023


The branch, master has been updated
       via  afbed653526 s3:utils: smbget fix a memory leak
      from  b0524830aaf s4:kdc: don't log an error if msDS-AllowedToActOnBehalfOfOtherIdentity is missing

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit afbed653526b572f7309e67ed742a76ef7b2b8ec
Author: Jones Syue <jonessyue at qnap.com>
Date:   Tue Jun 27 17:19:59 2023 +0800

    s3:utils: smbget fix a memory leak
    
    Using smbget to download files recursively (-R).
    
    If smbget found that a file is already existed in the destination,
    smbget would said 'File exists', return early, and 'newname' allocated
    memory is never freed, this is found by valgrind.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15403
    
    Signed-off-by: Jones Syue <jonessyue at qnap.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Wed Jun 28 07:02:34 UTC 2023 on atb-devel-224

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/smbget.c | 1 +
 1 file changed, 1 insertion(+)


Changeset truncated at 500 lines:

diff --git a/source3/utils/smbget.c b/source3/utils/smbget.c
index 00bf20e8192..5c99dcf918a 100644
--- a/source3/utils/smbget.c
+++ b/source3/utils/smbget.c
@@ -246,6 +246,7 @@ static bool smb_download_dir(const char *base, const char *name, int resume)
 		if (!ok) {
 			fprintf(stderr, "Failed to download %s: %s\n",
 				newname, strerror(errno));
+			free(newname);
 			free(tmpname);
 			return false;
 		}


-- 
Samba Shared Repository



More information about the samba-cvs mailing list