[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

The branch, master has been updated
       via  de5d31f452b s3:smbstatus: go to cmdline_messaging_context_free
      from  7ffa732d828 s3: smbd: Move check_fsp_open() and check_fsp() to smb1_reply.c

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit de5d31f452b2445bd92b1746efb05aa096716af8
Author: Jones Syue <jonessyue at qnap.com>
Date:   Wed Jan 11 16:59:42 2023 +0800

    s3:smbstatus: go to cmdline_messaging_context_free
    
    If the locking.tdb is not found,
    (for example, fresh new installed samba server is not running yet)
    smbstatus utility would exit earlier,
    and lock files are left behind in the directory 'msg.sock' and 'msg.lock'.
    Consider that a script to run smbstatus utility in a loop,
    this might result in used space slowly growing-up on the underlying filesystem.
    Since the samba server is not running yet,
    there is no cleanupd daemon could delete these files to reclaim space.
    
    Supposed to use 'ret = 0; goto done;' instead of exit(0),
    this would go through the cmdline_messaging_context_free() which deletes
    the lock files in the directory msg.sock and msg.lock before smbstatus
    utility is exiting.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15282
    
    Signed-off-by: Jones Syue <jonessyue at qnap.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Wed Jan 11 17:08:10 UTC 2023 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/status.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/status.c b/source3/utils/status.c
index d1c69c512a8..cca8b7d6cb2 100644
--- a/source3/utils/status.c
+++ b/source3/utils/status.c
@@ -1185,7 +1185,8 @@ int main(int argc, const char *argv[])
 			fprintf(stderr, "This is normal if an SMB client has never "
 				 "connected to your server.\n");
 			TALLOC_FREE(db_path);
-			exit(0);
+			ret = 0;
+			goto done;
 		} else {
 			TALLOC_FREE(db);
 			TALLOC_FREE(db_path);


-- 
Samba Shared Repository