[SCM] Samba Shared Repository - branch master updated
Andrew Bartlett
abartlet at samba.org
Fri Dec 8 03:26:02 UTC 2023
The branch, master has been updated
via 992f7625211 selftest: Remove unused import
via 5c4ee07ea2e Revert "s4:torture: Increase multichannel timeout"
via b4039bf6908 s4:ntvfs: Remove trailing whitespace
via 43c375515f2 pymessaging: Remove trailing whitespace
via 251f39a9fe6 s4:kdc: Remove unused includes
via 0982d030a49 s4:include: Fix code spelling
via 3d04f62e179 s4:include: Remove trailing whitespace
via b58cd077bc8 s4:dsdb: Fix code spelling
via 64f66273292 s4:dsdb: Remove trailing whitespace
via 9ebe4de113b s4:dsdb: Use portable integer constant INT64_MAX
via e1dc284fed2 s4:dsdb: Use portable integer constant INT64_MAX
via 6eec3ae6a65 s4:dsdb: Use portable integer constant INT64_MIN
via ccbaaf26067 s4:dsdb: Remove unused includes
via e8052ecad0e s4:dsdb: Remove trailing whitespace
via 235b518ccf8 s4:auth: Fix code spelling
via 513401806e2 s3:rpc_server: Fix code spelling
via ed908e937cb s3:modules: Fix code spelling
via f27ab6d9f5d s3:include: Fix code spelling
via 8a9e07ad864 s3:include: Remove trailing whitespace
via 9b06fd8ddae tests/krb5: Remove unused parameter
via 2e891f59b8c tests/krb5: Fix indentation
via d791bfae772 tests/dcerpc: Remove unused imports
via e7a2c4ba64b tests/dcerpc: Correct docstring
via 5287411be8d python:tests: Remove leftover debugging message
via 49f54e2bd62 python:tests: Remove unused imports
via abab561d443 python:tests: Remove unnecessary f‐strings
via 2eb7b95de38 python: Add missing word to comment
via c7ab99a8668 python: Fix code spelling
via b82abfe00cc gp: Remove unused import
via c62d17dbe70 security.idl: Remove trailing whitespace
via e05c3477fc4 librpc: Fix code spelling
via 4846ebbd8a6 librpc: Remove trailing whitespace
via 6e998655835 libcli/security: Fix code spelling
via b3199f2a696 libcli/security: Remove unused includes
via 8aa164ce403 util/data_blob: Fix code spelling
via c07f72a531a util/data_blob: Remove trailing whitespace
via 1947bd6d6d9 util/charset: Remove trailing whitespace
via a56bf3fa261 lib/torture: Remove trailing whitespace
via 0691a112f6d talloc: Fix documentation
via ac860150413 lib/fuzzing: Fix code spelling
via f6bc1ad9667 ldb: Fix code spelling
via 2a9e8849ad4 lib:crypto: Remove unused Rijndael cipher header
via 7658c9bf0a9 lib:crypto: Remove redundant array zeroing
via af2b5f46b9a docs-xml: Fix code spelling
via cec6c7e233c ctdb: Fix code spelling
via 265e3699ac3 ctdb: Remove trailing whitespace
via 18d9873e5d7 buildtools: Update docstring to be more accurate
via e607a59c806 auth:gensec: Zero digest array in error case
via 60e9e3e01cd tests/ndr: Add tests for Group Key Distribution Service blobs
via 2cb6e37e5b5 gkdi.idl: Add definitions for the Group Key Distribution Service
via 261d3ade8dd python:tests: Permit newer copyright notice
from 763b2efe69d s3:utils: Fix setting the debug level
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 992f76252114c09ddaad0204edd97af8043425b3
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 9 10:55:24 2023 +1300
selftest: Remove unused import
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Dec 8 03:25:20 UTC 2023 on atb-devel-224
commit 5c4ee07ea2eaa5b5d307b467f5b829547f5a3da8
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 30 11:57:08 2023 +1300
Revert "s4:torture: Increase multichannel timeout"
This reverts commit c6d0df787a1f6007e1f4594f68ff1f75a46bd293.
Said commit did not help with GitLab CI timeouts, but just made the CI
pipeline take longer when the test did time out.
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b4039bf69089feb5ba5d185fcf54696e4c3c005d
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Oct 24 16:24:03 2023 +1300
s4:ntvfs: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 43c375515f281f94ceabf678f80ef90884fe4f00
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Nov 14 13:07:01 2023 +1300
pymessaging: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 251f39a9fe637964da28bc2908ba9dcce0bbf9f3
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Dec 4 19:25:33 2023 +1300
s4:kdc: Remove unused includes
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0982d030a49ca903733873ca99d112b4cf2662b4
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 9 16:02:59 2023 +1300
s4:include: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3d04f62e17968878f76a5b7808dc4bc5553853c9
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 9 16:02:48 2023 +1300
s4:include: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b58cd077bc828c88b3446951891da01ecf132eea
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Dec 5 16:54:44 2023 +1300
s4:dsdb: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 64f66273292ef9d05af8480ba39e9c39c545f710
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Dec 6 14:39:45 2023 +1300
s4:dsdb: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9ebe4de113be0cde10f09148f0e06d34f4a30f9d
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Dec 4 16:24:15 2023 +1300
s4:dsdb: Use portable integer constant INT64_MAX
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e1dc284fed25639508c5ae1598ce95241e7bfaf8
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Dec 4 15:00:34 2023 +1300
s4:dsdb: Use portable integer constant INT64_MAX
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6eec3ae6a650384103941996a160de9120186e9e
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Dec 4 14:34:37 2023 +1300
s4:dsdb: Use portable integer constant INT64_MIN
Because it is written in hexadecimal, ‘0x8000000000000000LL’ is likely
going to be represented as an ‘unsigned long long int’. Negating it
actually will not change its value at all, so the unary minus achieves
nothing here.
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ccbaaf26067f9d722d5080b472e36f55e492ee1b
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Dec 4 14:30:43 2023 +1300
s4:dsdb: Remove unused includes
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e8052ecad0e8313d81f40607d71cf9a2c78446a0
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Dec 4 14:30:22 2023 +1300
s4:dsdb: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 235b518ccf86fa17a78bfa6e5ed654ed44d81f8d
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Nov 21 15:03:55 2023 +1300
s4:auth: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 513401806e201282da1eb9faad765ef7ac0df879
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Nov 8 21:08:40 2023 +1300
s3:rpc_server: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ed908e937cbb5615e9246d74d727c424826ebd31
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Nov 8 16:56:58 2023 +1300
s3:modules: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f27ab6d9f5d5d9134160230c61512810fb91d495
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 9 16:02:32 2023 +1300
s3:include: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8a9e07ad864bc87daec7e598667da0c3ccdf902a
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 9 16:02:18 2023 +1300
s3:include: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9b06fd8ddae45a3c23c26b380f400c1e71c10854
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 23 16:08:00 2023 +1300
tests/krb5: Remove unused parameter
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2e891f59b8cdb6b566e703a802236b96d5a0671c
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Nov 8 14:41:18 2023 +1300
tests/krb5: Fix indentation
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d791bfae772ed267e62023a61cacbc7d89c3354c
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Dec 7 10:03:09 2023 +1300
tests/dcerpc: Remove unused imports
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e7a2c4ba64b154123aeeefd414faaa9f6a5ffc1e
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Dec 7 10:02:41 2023 +1300
tests/dcerpc: Correct docstring
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5287411be8d6d21e66a379612af4da159567d3cf
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Fri Nov 24 15:03:40 2023 +1300
python:tests: Remove leftover debugging message
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 49f54e2bd6202eddfd772a9c7f0a5d8287d9783c
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Nov 7 12:35:10 2023 +1300
python:tests: Remove unused imports
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit abab561d443590a8ebe68e70efc0947d342e1973
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Fri Nov 24 14:46:56 2023 +1300
python:tests: Remove unnecessary f‐strings
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2eb7b95de388099587c9fbfdb1d0425e585dd521
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Fri Nov 24 11:39:47 2023 +1300
python: Add missing word to comment
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c7ab99a86681584b384e966a24ca2f9f5921c079
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Fri Nov 24 11:39:16 2023 +1300
python: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b82abfe00cc24b0e1d51d54de82e1f379d1f43e9
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Oct 16 18:12:49 2023 +1300
gp: Remove unused import
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c62d17dbe70dc65cd1bd08a59a57956154a7f46a
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Nov 27 12:57:30 2023 +1300
security.idl: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e05c3477fc41f96459b2c5790d6ae52f71993961
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Nov 22 14:40:31 2023 +1300
librpc: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4846ebbd8a60d46fd94eb9f15b2b3039f4637f44
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Nov 22 14:39:17 2023 +1300
librpc: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6e9986558351278fade8bccd30624e789aa07ca7
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 30 08:18:49 2023 +1300
libcli/security: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b3199f2a6966adb532572d81d80fd708ed2e269d
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 30 08:18:31 2023 +1300
libcli/security: Remove unused includes
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8aa164ce403b0151624dfc6ce9d3c84dd4a3c0b6
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 23 16:23:51 2023 +1300
util/data_blob: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c07f72a531a7a7d39c5f11af684e1369229c39b8
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 23 16:23:29 2023 +1300
util/data_blob: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1947bd6d6d9b774e811ea0ad20ad282bc5fc2e2b
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Nov 14 11:02:15 2023 +1300
util/charset: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a56bf3fa2618884623f05d1f0cabf90ea883bc7f
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Oct 19 12:32:35 2023 +1300
lib/torture: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0691a112f6d55f657077b9b4ebba716264058d98
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Nov 15 11:23:03 2023 +1300
talloc: Fix documentation
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ac86015041337e3547369f7d93ee41825fff1d6e
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Nov 27 19:41:13 2023 +1300
lib/fuzzing: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f6bc1ad96670fd450ca5cfaec6263d676b251e62
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Dec 5 11:41:24 2023 +1300
ldb: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2a9e8849ad4d606570d9f490f167734ad540687a
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Dec 5 15:36:37 2023 +1300
lib:crypto: Remove unused Rijndael cipher header
The corresponding code was removed with commit
11b3c6826d19d60937f75825075fc5eb67385e11.
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7658c9bf0a9c99e3f200571d6307334a851d0d06
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 30 16:20:02 2023 +1300
lib:crypto: Remove redundant array zeroing
The call to memset_s() was supposed to replace the use of
ZERO_ARRAY_LEN(), but somehow both lines have crept in.
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit af2b5f46b9a363a0b24c490eb0f07452cd3117af
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 16 10:46:09 2023 +1300
docs-xml: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cec6c7e233ce212b875bd5615d4986b4eec5972b
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Fri Nov 24 12:30:03 2023 +1300
ctdb: Fix code spelling
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 265e3699ac3821d109ee2c3c239f7d1f9559b8ce
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Fri Nov 24 12:29:15 2023 +1300
ctdb: Remove trailing whitespace
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 18d9873e5d7bdb331ff56b1cac3b697f07041525
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Thu Nov 9 13:17:24 2023 +1300
buildtools: Update docstring to be more accurate
Some more possibilities for output files have been introduced since
commit e916aff9e1d44c3599c30b9ea32d03921f6403f4.
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e607a59c8065ac4676a409e6a664ac7f5bad94c3
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Tue Dec 5 15:47:23 2023 +1300
auth:gensec: Zero digest array in error case
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 60e9e3e01cd48c66dba9417783568895be67fc94
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Fri Dec 8 13:00:34 2023 +1300
tests/ndr: Add tests for Group Key Distribution Service blobs
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2cb6e37e5b55ce00eb478685ad126daa6be523fe
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Mon Nov 13 17:08:58 2023 +1300
gkdi.idl: Add definitions for the Group Key Distribution Service
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 261d3ade8ddae1ecbc49bfe839ad9ffbdbc104f1
Author: Joseph Sutton <josephsutton at catalyst.net.nz>
Date: Wed Dec 6 16:07:54 2023 +1300
python:tests: Permit newer copyright notice
We can use an HTTPS URL (https://www.gnu.org/licenses/) now.
Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
-----------------------------------------------------------------------
Summary of changes:
auth/gensec/schannel.c | 3 +-
buildtools/wafsamba/samba_pidl.py | 2 +-
ctdb/server/ctdb_ltdb_server.c | 40 +--
docs-xml/Makefile | 2 +-
lib/crypto/gnutls_sp800_108.c | 1 -
lib/crypto/rijndael-alg-fst.h | 46 ---
lib/fuzzing/fuzz_conditional_ace_blob.c | 2 +-
lib/fuzzing/wscript_build | 2 +-
lib/ldb/include/ldb.h | 6 +-
lib/talloc/talloc.c | 4 +-
lib/torture/torture.h | 72 ++---
lib/util/charset/codepoints.c | 12 +-
lib/util/data_blob.h | 16 +-
libcli/security/claims-conversions.c | 6 +-
libcli/security/sddl_conditional_ace.c | 2 +-
librpc/idl/gkdi.idl | 111 +++++++
librpc/idl/security.idl | 30 +-
librpc/idl/wscript_build | 7 +-
librpc/wscript_build | 13 +-
python/samba/gp/gp_drive_maps_ext.py | 3 +-
python/samba/provision/__init__.py | 4 +-
python/samba/tests/blackbox/claims.py | 10 +-
python/samba/tests/conditional_ace_bytes.py | 7 +-
python/samba/tests/conditional_ace_claims.py | 26 +-
python/samba/tests/dcerpc/lsa.py | 4 +-
python/samba/tests/krb5/conditional_ace_tests.py | 12 +-
python/samba/tests/krb5/raw_testcase.py | 7 +-
python/samba/tests/ndr/gkdi.py | 392 +++++++++++++++++++++++
python/samba/tests/source.py | 23 +-
selftest/tests.py | 1 +
source3/include/includes.h | 14 +-
source3/modules/nfs4_acls.c | 2 +-
source3/rpc_server/samr/srv_samr_nt.c | 2 +-
source4/auth/kerberos/kerberos_util.c | 2 +-
source4/dsdb/common/util.c | 10 +-
source4/dsdb/samdb/ldb_modules/audit_util.c | 2 +-
source4/dsdb/samdb/ldb_modules/operational.c | 41 ++-
source4/dsdb/samdb/ldb_modules/util.c | 8 +-
source4/dsdb/samdb/samdb.h | 16 +-
source4/include/includes.h | 10 +-
source4/kdc/ad_claims.c | 4 -
source4/lib/messaging/pymessaging.c | 12 +-
source4/librpc/wscript_build | 7 +
source4/ntvfs/posix/pvfs_dirlist.c | 30 +-
source4/selftest/tests.py | 2 +-
source4/torture/smb2/multichannel.c | 2 +-
46 files changed, 750 insertions(+), 280 deletions(-)
delete mode 100644 lib/crypto/rijndael-alg-fst.h
create mode 100644 librpc/idl/gkdi.idl
create mode 100755 python/samba/tests/ndr/gkdi.py
Changeset truncated at 500 lines:
diff --git a/auth/gensec/schannel.c b/auth/gensec/schannel.c
index 1f8680743e9..86527fe4685 100644
--- a/auth/gensec/schannel.c
+++ b/auth/gensec/schannel.c
@@ -208,12 +208,11 @@ static NTSTATUS netsec_do_seq_num(struct schannel_state *state,
checksum,
checksum_length,
_sequence_key);
+ ZERO_ARRAY(digest1);
if (rc < 0) {
return gnutls_error_to_ntstatus(rc, NT_STATUS_HMAC_NOT_SUPPORTED);
}
- ZERO_ARRAY(digest1);
-
rc = gnutls_cipher_init(&cipher_hnd,
GNUTLS_CIPHER_ARCFOUR_128,
&sequence_key,
diff --git a/buildtools/wafsamba/samba_pidl.py b/buildtools/wafsamba/samba_pidl.py
index a161a77bcb5..72997c8bf84 100644
--- a/buildtools/wafsamba/samba_pidl.py
+++ b/buildtools/wafsamba/samba_pidl.py
@@ -10,7 +10,7 @@ def SAMBA_PIDL(bld, pname, source,
output_dir='.',
generate_tables=True):
'''Build a IDL file using pidl.
- This will produce up to 13 output files depending on the options used'''
+ This will produce up to 17 output files depending on the options used'''
bname = source[0:-4] # strip off the .idl suffix
bname = os.path.basename(bname)
diff --git a/ctdb/server/ctdb_ltdb_server.c b/ctdb/server/ctdb_ltdb_server.c
index 83762d97925..e2cb9165c71 100644
--- a/ctdb/server/ctdb_ltdb_server.c
+++ b/ctdb/server/ctdb_ltdb_server.c
@@ -1,4 +1,4 @@
-/*
+/*
ctdb ltdb code - server side
Copyright (C) Andrew Tridgell 2007
@@ -7,12 +7,12 @@
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
-
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
@@ -287,7 +287,7 @@ static void lock_fetch_callback(void *p, bool locked)
-1: means that it failed to get the lock, and won't retry
-2: means that it failed to get the lock immediately, but will retry
*/
-int ctdb_ltdb_lock_requeue(struct ctdb_db_context *ctdb_db,
+int ctdb_ltdb_lock_requeue(struct ctdb_db_context *ctdb_db,
TDB_DATA key, struct ctdb_req_header *hdr,
void (*recv_pkt)(void *, struct ctdb_req_header *),
void *recv_context, bool ignore_generation)
@@ -296,7 +296,7 @@ int ctdb_ltdb_lock_requeue(struct ctdb_db_context *ctdb_db,
struct tdb_context *tdb = ctdb_db->ltdb->tdb;
struct lock_request *lreq;
struct lock_fetch_state *state;
-
+
ret = tdb_chainlock_nonblock(tdb, key);
if (ret != 0 &&
@@ -343,15 +343,15 @@ int ctdb_ltdb_lock_requeue(struct ctdb_db_context *ctdb_db,
/*
a variant of ctdb_ltdb_lock_requeue that also fetches the record
*/
-int ctdb_ltdb_lock_fetch_requeue(struct ctdb_db_context *ctdb_db,
- TDB_DATA key, struct ctdb_ltdb_header *header,
+int ctdb_ltdb_lock_fetch_requeue(struct ctdb_db_context *ctdb_db,
+ TDB_DATA key, struct ctdb_ltdb_header *header,
struct ctdb_req_header *hdr, TDB_DATA *data,
void (*recv_pkt)(void *, struct ctdb_req_header *),
void *recv_context, bool ignore_generation)
{
int ret;
- ret = ctdb_ltdb_lock_requeue(ctdb_db, key, hdr, recv_pkt,
+ ret = ctdb_ltdb_lock_requeue(ctdb_db, key, hdr, recv_pkt,
recv_context, ignore_generation);
if (ret != 0) {
return ret;
@@ -461,8 +461,8 @@ int ctdb_update_persistent_health(struct ctdb_context *ctdb,
}
} else if (old_reason && num_healthy_nodes == 0) {
/*
- * If the reason indicates ok, but there where no healthy nodes
- * available, that it means, we have not recovered valid content
+ * If the reason indicates ok, but there were no healthy nodes
+ * available, it means that we have not recovered valid content
* of the db. So if there's an old reason, prefix it with
* "NO-HEALTHY-NODES - "
*/
@@ -718,8 +718,8 @@ int ctdb_set_db_readonly(struct ctdb_context *ctdb, struct ctdb_db_context *ctdb
DEBUG(DEBUG_CRIT,("Failed to asprintf the tracking database\n"));
return -1;
}
- ctdb_db->rottdb = tdb_open(ropath,
- ctdb->tunable.database_hash_size,
+ ctdb_db->rottdb = tdb_open(ropath,
+ ctdb->tunable.database_hash_size,
TDB_NOLOCK|TDB_CLEAR_IF_FIRST|TDB_NOSYNC,
O_CREAT|O_RDWR, 0600);
if (ctdb_db->rottdb == NULL) {
@@ -842,8 +842,8 @@ static int ctdb_local_attach(struct ctdb_context *ctdb, const char *db_name,
again:
ctdb_db->ltdb = tdb_wrap_open(ctdb_db, ctdb_db->db_path,
- ctdb->tunable.database_hash_size,
- tdb_flags,
+ ctdb->tunable.database_hash_size,
+ tdb_flags,
O_CREAT|O_RDWR, mode);
if (ctdb_db->ltdb == NULL) {
struct stat st;
@@ -945,7 +945,7 @@ again:
tdb_add_flags(ctdb_db->ltdb->tdb, tdb_flags);
- /* set up a rb tree we can use to track which records we have a
+ /* set up a rb tree we can use to track which records we have a
fetch-lock in-flight for so we can defer any additional calls
for the same record.
*/
@@ -969,7 +969,7 @@ again:
/* setting this can help some high churn databases */
tdb_set_max_dead(ctdb_db->ltdb->tdb, ctdb->tunable.database_max_dead);
- /*
+ /*
all databases support the "null" function. we need this in
order to do forced migration of records
*/
@@ -980,7 +980,7 @@ again:
return -1;
}
- /*
+ /*
all databases support the "fetch" function. we need this
for efficient Samba3 ctdb fetch
*/
@@ -991,7 +991,7 @@ again:
return -1;
}
- /*
+ /*
all databases support the "fetch_with_header" function. we need this
for efficient readonly record fetches
*/
@@ -1080,7 +1080,7 @@ int ctdb_process_deferred_attach(struct ctdb_context *ctdb)
{
struct ctdb_deferred_attach_context *da_ctx;
- /* call it from the main event loop as soon as the current event
+ /* call it from the main event loop as soon as the current event
finishes.
*/
while ((da_ctx = ctdb->deferred_attach) != NULL) {
@@ -1325,7 +1325,7 @@ static int ctdb_attach_persistent(struct ctdb_context *ctdb,
size_t len = strlen(de->d_name);
uint32_t node;
int invalid_name = 0;
-
+
s = talloc_strdup(ctdb, de->d_name);
if (s == NULL) {
closedir(d);
diff --git a/docs-xml/Makefile b/docs-xml/Makefile
index ae50b14d79a..0b5f2a6bd06 100644
--- a/docs-xml/Makefile
+++ b/docs-xml/Makefile
@@ -34,7 +34,7 @@ endif
help:
@echo "Supported make targets:"
@echo " release - Build the docs needed for a Samba release"
- @echo " all - Build all docs that can be build using the utilities found by configure"
+ @echo " all - Build all docs that can be built using the utilities found by configure"
@echo " everything - Build all of the above"
@echo " pdf,tex,ps,manpages,htmlhelp - Build specific output format"
@echo " html - Build multi-file HTML versions"
diff --git a/lib/crypto/gnutls_sp800_108.c b/lib/crypto/gnutls_sp800_108.c
index 65710657bae..fb0aa039213 100644
--- a/lib/crypto/gnutls_sp800_108.c
+++ b/lib/crypto/gnutls_sp800_108.c
@@ -224,7 +224,6 @@ out:
if (!NT_STATUS_IS_OK(status)) {
/* Hide the evidence. */
memset_s(KO, KO_len, 0, KO_idx);
- ZERO_ARRAY_LEN(KO, KO_idx);
}
return status;
diff --git a/lib/crypto/rijndael-alg-fst.h b/lib/crypto/rijndael-alg-fst.h
deleted file mode 100644
index d5d96ed5b40..00000000000
--- a/lib/crypto/rijndael-alg-fst.h
+++ /dev/null
@@ -1,46 +0,0 @@
-/* $NetBSD: rijndael-alg-fst.h,v 1.2 2000/10/02 17:19:15 itojun Exp $ */
-/* $KAME: rijndael-alg-fst.h,v 1.5 2003/07/15 10:47:16 itojun Exp $ */
-/**
- * rijndael-alg-fst.h
- *
- * @version 3.0 (December 2000)
- *
- * Optimised ANSI C code for the Rijndael cipher (now AES)
- *
- * @author Vincent Rijmen <vincent.rijmen at esat.kuleuven.ac.be>
- * @author Antoon Bosselaers <antoon.bosselaers at esat.kuleuven.ac.be>
- * @author Paulo Barreto <paulo.barreto at terra.com.br>
- *
- * This code is hereby placed in the public domain.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHORS ''AS IS'' AND ANY EXPRESS
- * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHORS OR CONTRIBUTORS BE
- * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
- * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
- * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
- * OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
- * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-#ifndef LIB_CRYPTO_RIJNDAEL_ALG_FST_H
-#define LIB_CRYPTO_RIJNDAEL_ALG_FST_H
-
-/* symbol renaming */
-#define rijndaelKeySetupEnc _samba_rijndaelKeySetupEnc
-#define rijndaelKeySetupDec _samba_rijndaelKeySetupDec
-#define rijndaelEncrypt _samba_rijndaelEncrypt
-#define rijndaelDecrypt _samba_rijndaelDecrypt
-
-#define RIJNDAEL_MAXKC (256/32)
-#define RIJNDAEL_MAXKB (256/8)
-#define RIJNDAEL_MAXNR 14
-
-int rijndaelKeySetupEnc(uint32_t rk[/*4*(Nr + 1)*/], const uint8_t cipherKey[], int keyBits);
-int rijndaelKeySetupDec(uint32_t rk[/*4*(Nr + 1)*/], const uint8_t cipherKey[], int keyBits);
-void rijndaelEncrypt(const uint32_t rk[/*4*(Nr + 1)*/], int Nr, const uint8_t pt[16], uint8_t ct[16]);
-void rijndaelDecrypt(const uint32_t rk[/*4*(Nr + 1)*/], int Nr, const uint8_t ct[16], uint8_t pt[16]);
-
-#endif /* LIB_CRYPTO_RIJNDAEL_ALG_FST_H */
diff --git a/lib/fuzzing/fuzz_conditional_ace_blob.c b/lib/fuzzing/fuzz_conditional_ace_blob.c
index 70bb5723c51..ed0bbd536bc 100644
--- a/lib/fuzzing/fuzz_conditional_ace_blob.c
+++ b/lib/fuzzing/fuzz_conditional_ace_blob.c
@@ -123,7 +123,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len)
* abort();
* }
*
- * but that isn't really fair. The docompilation into SDDL
+ * but that isn't really fair. The decompilation into SDDL
* does not make thorough sanity checks because that is not
* its job -- it is just trying to depict what is there -- and
* there are many ambiguous decompilations.
diff --git a/lib/fuzzing/wscript_build b/lib/fuzzing/wscript_build
index 1e796bf3cb6..5a9801321aa 100644
--- a/lib/fuzzing/wscript_build
+++ b/lib/fuzzing/wscript_build
@@ -206,7 +206,7 @@ def SAMBA_NDR_FUZZ(bld, interface, auto_deps=False,
Build.BuildContext.SAMBA_NDR_FUZZ = SAMBA_NDR_FUZZ
-# fuzz_ndr_X is generated from the list if IDL fed to PIDL
+# fuzz_ndr_X is generated from the list of IDL fed to PIDL
# however there are exceptions to the normal pattern
bld.SAMBA_NDR_FUZZ('iremotewinspool') # winspool.idl
bld.SAMBA_NDR_FUZZ('FileServerVssAgent') # fsvrp.idl
diff --git a/lib/ldb/include/ldb.h b/lib/ldb/include/ldb.h
index 825df7401bb..95c7d527f84 100644
--- a/lib/ldb/include/ldb.h
+++ b/lib/ldb/include/ldb.h
@@ -1864,7 +1864,7 @@ struct ldb_dn *ldb_dn_new(TALLOC_CTX *mem_ctx, struct ldb_context *ldb, const ch
Allocate a new DN from a printf style format string and arguments
\param mem_ctx TALLOC context to return resulting ldb_dn structure on
- \param new_fms The new DN as a format string (plus arguments)
+ \param new_fmt The new DN as a format string (plus arguments)
\note The DN will not be parsed at this time. Use ldb_dn_validate to tell if the DN is syntactically correct
*/
@@ -2093,7 +2093,7 @@ struct ldb_message *ldb_msg_copy(TALLOC_CTX *mem_ctx,
const struct ldb_message *msg);
/*
- * ldb_msg_canonicalize() is now depreciated
+ * ldb_msg_canonicalize() is now deprecated
* Please use ldb_msg_normalize() instead
*
* NOTE: Returned ldb_message object is allocated
@@ -2111,7 +2111,7 @@ int ldb_msg_normalize(struct ldb_context *ldb,
/*
- * ldb_msg_diff() is now depreciated
+ * ldb_msg_diff() is now deprecated
* Please use ldb_msg_difference() instead
*
* NOTE: Returned ldb_message object is allocated
diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c
index 14e9e389f54..3a93a82e456 100644
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -1253,7 +1253,7 @@ static inline size_t _talloc_total_limit_size(const void *ptr,
struct talloc_memlimit *new_limit);
/*
- move a lump of memory from one talloc context to another return the
+ move a lump of memory from one talloc context to another returning the
ptr on success, or NULL if it could not be transferred.
passing NULL as ptr will always return NULL with no side effects.
*/
@@ -1335,7 +1335,7 @@ static void *_talloc_steal_internal(const void *new_ctx, const void *ptr)
}
/*
- move a lump of memory from one talloc context to another return the
+ move a lump of memory from one talloc context to another returning the
ptr on success, or NULL if it could not be transferred.
passing NULL as ptr will always return NULL with no side effects.
*/
diff --git a/lib/torture/torture.h b/lib/torture/torture.h
index 2d4376a3eb3..2e86e3173cc 100644
--- a/lib/torture/torture.h
+++ b/lib/torture/torture.h
@@ -1,19 +1,19 @@
-/*
+/*
Unix SMB/CIFS implementation.
SMB torture UI functions
Copyright (C) Jelmer Vernooij 2006
-
+
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
-
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
@@ -31,8 +31,8 @@ struct torture_results;
* Arranged in precedence order. TORTURE_ERROR has the highest priority;
* TORTURE_OK the lowest.
*/
-enum torture_result {
- TORTURE_OK=0,
+enum torture_result {
+ TORTURE_OK=0,
TORTURE_SKIP=1,
TORTURE_FAIL=2,
TORTURE_ERROR=3
@@ -45,8 +45,8 @@ enum torture_progress_whence {
TORTURE_PROGRESS_PUSH,
};
-/*
- * These callbacks should be implemented by any backend that wishes
+/*
+ * These callbacks should be implemented by any backend that wishes
* to listen to reports from the torture tests.
*/
struct torture_ui_ops
@@ -56,12 +56,12 @@ struct torture_ui_ops
void (*warning) (struct torture_context *, const char *);
void (*suite_start) (struct torture_context *, struct torture_suite *);
void (*suite_finish) (struct torture_context *, struct torture_suite *);
- void (*tcase_start) (struct torture_context *, struct torture_tcase *);
+ void (*tcase_start) (struct torture_context *, struct torture_tcase *);
void (*tcase_finish) (struct torture_context *, struct torture_tcase *);
- void (*test_start) (struct torture_context *,
+ void (*test_start) (struct torture_context *,
struct torture_tcase *,
struct torture_test *);
- void (*test_result) (struct torture_context *,
+ void (*test_result) (struct torture_context *,
enum torture_result, const char *reason);
void (*progress) (struct torture_context *, int offset, enum torture_progress_whence whence);
void (*report_time) (struct torture_context *);
@@ -78,12 +78,12 @@ void torture_ui_test_result(struct torture_context *context,
void torture_ui_report_time(struct torture_context *context);
/*
- * Holds information about a specific run of the testsuite.
- * The data in this structure should be considered private to
- * the torture tests and should only be used directly by the torture
+ * Holds information about a specific run of the testsuite.
+ * The data in this structure should be considered private to
+ * the torture tests and should only be used directly by the torture
* code and the ui backends.
*
- * Torture tests should instead call the torture_*() macros and functions
+ * Torture tests should instead call the torture_*() macros and functions
* specified below.
*/
@@ -127,7 +127,7 @@ struct torture_results
bool returncode;
};
-/*
+/*
* Describes a particular torture test
*/
struct torture_test {
@@ -137,18 +137,18 @@ struct torture_test {
/** Long description for the test. */
const char *description;
- /** Whether this is a dangerous test
+ /** Whether this is a dangerous test
* (can corrupt the remote servers data or bring it down). */
bool dangerous;
/** Function to call to run this test */
- bool (*run) (struct torture_context *torture_ctx,
+ bool (*run) (struct torture_context *torture_ctx,
struct torture_tcase *tcase,
struct torture_test *test);
struct torture_test *prev, *next;
- /** Pointer to the actual test function. This is run by the
+ /** Pointer to the actual test function. This is run by the
* run() function above. */
void *fn;
@@ -158,14 +158,14 @@ struct torture_test {
struct torture_tcase *tcase;
};
-/*
+/*
* Describes a particular test case.
*/
struct torture_tcase {
const char *name;
const char *description;
bool (*setup) (struct torture_context *tcase, void **data);
- bool (*teardown) (struct torture_context *tcase, void *data);
+ bool (*teardown) (struct torture_context *tcase, void *data);
bool fixture_persistent;
void *data;
struct torture_test *tests;
@@ -243,16 +243,16 @@ void torture_subunit_prefix_reset(struct torture_context *ctx,
bool torture_run_suite(struct torture_context *context,
struct torture_suite *suite);
-/* Run the specified testsuite recursively, but only the specified
+/* Run the specified testsuite recursively, but only the specified
* tests */
-bool torture_run_suite_restricted(struct torture_context *context,
+bool torture_run_suite_restricted(struct torture_context *context,
struct torture_suite *suite, const char **restricted);
/* Run the specified testcase */
bool torture_run_tcase(struct torture_context *context,
struct torture_tcase *tcase);
-bool torture_run_tcase_restricted(struct torture_context *context,
+bool torture_run_tcase_restricted(struct torture_context *context,
struct torture_tcase *tcase, const char **restricted);
/* Run the specified test */
@@ -825,30 +825,30 @@ static inline void torture_dump_data_str_cb(const char *buf, void *private_data)
/* Getting settings */
const char *torture_setting_string(struct torture_context *test, \
- const char *name,
+ const char *name,
const char *default_value);
-int torture_setting_int(struct torture_context *test,
- const char *name,
+int torture_setting_int(struct torture_context *test,
+ const char *name,
int default_value);
--
Samba Shared Repository
More information about the samba-cvs
mailing list