[SCM] Samba Shared Repository - branch v4-19-stable updated

[Jule Anger]

The branch, v4-19-stable has been updated
       via  0e9c171f5f6 VERSION: Disable GIT_SNAPSHOT for the 4.19.0rc4 release.
       via  23b4753dc1d WHATSNEW: Add release notes for Samba 4.19.0rc4.
       via  fb774d5d425 util: Avoid logging to multiple backends for stdout/stderr
       via  645fc88b65c samba-tool: Allow LDB URL to be None
       via  a3ce262afd4 WHATSNEW: Add Resource Based Constrained Delegation (RBCD) feature for Heimdal
       via  ab0365cf489 VERSION: Bump version up to Samba 4.19.0rc4...
      from  6be33d37524 VERSION: Disable GIT_SNAPSHOT for the 4.19.0rc3 release.

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-19-stable


- Log -----------------------------------------------------------------
-----------------------------------------------------------------------

Summary of changes:
 VERSION                             |  2 +-
 WHATSNEW.txt                        | 30 +++++++++++++++++++++++++++++-
 lib/util/debug.c                    | 36 +++++++++++++-----------------------
 python/samba/netcmd/domain/level.py |  2 +-
 4 files changed, 44 insertions(+), 26 deletions(-)


Changeset truncated at 500 lines:

diff --git a/VERSION b/VERSION
index 9744016e64d..1a2b292e111 100644
--- a/VERSION
+++ b/VERSION
@@ -87,7 +87,7 @@ SAMBA_VERSION_PRE_RELEASE=
 # e.g. SAMBA_VERSION_RC_RELEASE=1                      #
 #  ->  "3.0.0rc1"                                      #
 ########################################################
-SAMBA_VERSION_RC_RELEASE=3
+SAMBA_VERSION_RC_RELEASE=4
 
 ########################################################
 # To mark SVN snapshots this should be set to 'yes'    #
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index d4315046af4..97eaec57b1e 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -1,7 +1,7 @@
 Release Announcements
 =====================
 
-This is the third release candidate of Samba 4.19.  This is *not*
+This is the fourth release candidate of Samba 4.19.  This is *not*
 intended for production environments and is designed for testing
 purposes only.  Please report any defects via the Samba bug reporting
 system at https://bugzilla.samba.org/.
@@ -135,6 +135,23 @@ member server's own domain, to only consume a header and 4 bytes per
 group in the PAC, not a full-length SID worth of space each.  This is
 known as "Resource SID compression".
 
+Resource Based Constrained Delegation (RBCD) support in both MIT and Heimdal
+-----------------------------------------------------------------------------
+
+Samba AD DC built with MIT Kerberos (1.20 and later) has offered RBCD
+support since Samba 4.17.  Samba 4.19 brings this feature to the
+default Heimdal KDC.
+
+Samba 4.17 added to samba-tool delegation the 'add-principal' and
+'del-principal' subcommands in order to manage RBCD, and the database
+changes made by these tools are now honoured by the Heimdal KDC once
+Samba is upgraded.
+
+Likewise, now both MIT (1.20 and later) and Heimdal KDCs add the
+Asserted Identity [1] SID into the PAC for constrained delegation.
+
+[1] https://docs.microsoft.com/en-us/windows-server/security/kerberos/kerberos-constrained-delegation-overview
+
 New samba-tool support for silos, claims, sites and subnets.
 ------------------------------------------------------------
 
@@ -235,6 +252,17 @@ smb.conf changes
   directory name cache size               Removed
 
 
+CHANGES SINCE 4.19.0rc3
+=======================
+
+o  Martin Schwenke <mschwenke at ddn.com>
+   * BUG 15460: Logging to stdout/stderr with DEBUG_SYSLOG_FORMAT_ALWAYS can log
+     to syslog.
+
+o  Joseph Sutton <josephsutton at catalyst.net.nz>
+   * BUG 15458: ‘samba-tool domain level raise’ fails unless given a URL.
+
+
 CHANGES SINCE 4.19.0rc2
 =======================
 
diff --git a/lib/util/debug.c b/lib/util/debug.c
index b83075cb239..0e13fa564e3 100644
--- a/lib/util/debug.c
+++ b/lib/util/debug.c
@@ -1559,25 +1559,10 @@ void check_log_size( void )
 static void Debug1(const char *msg, size_t msg_len)
 {
 	int old_errno = errno;
-	enum debug_logtype logtype = state.logtype;
 
 	debug_count++;
 
-	if (state.settings.debug_syslog_format == DEBUG_SYSLOG_FORMAT_ALWAYS) {
-		switch(state.logtype) {
-		case DEBUG_STDOUT:
-		case DEBUG_STDERR:
-		case DEBUG_DEFAULT_STDOUT:
-		case DEBUG_DEFAULT_STDERR:
-			/* Behave the same as logging to a file */
-			logtype = DEBUG_FILE;
-			break;
-		default:
-			break;
-		}
-	}
-
-	switch(logtype) {
+	switch(state.logtype) {
 	case DEBUG_CALLBACK:
 		debug_callback_log(msg, msg_len, current_msg_level);
 		break;
@@ -1585,13 +1570,18 @@ static void Debug1(const char *msg, size_t msg_len)
 	case DEBUG_STDERR:
 	case DEBUG_DEFAULT_STDOUT:
 	case DEBUG_DEFAULT_STDERR:
-		if (dbgc_config[DBGC_ALL].fd > 0) {
-			ssize_t ret;
-			do {
-				ret = write(dbgc_config[DBGC_ALL].fd,
-					    msg,
-					    msg_len);
-			} while (ret == -1 && errno == EINTR);
+		if (state.settings.debug_syslog_format ==
+		    DEBUG_SYSLOG_FORMAT_ALWAYS) {
+			debug_file_log(current_msg_level, msg, msg_len);
+		} else {
+			if (dbgc_config[DBGC_ALL].fd > 0) {
+				ssize_t ret;
+				do {
+					ret = write(dbgc_config[DBGC_ALL].fd,
+						    msg,
+						    msg_len);
+				} while (ret == -1 && errno == EINTR);
+			}
 		}
 		break;
 	case DEBUG_FILE:
diff --git a/python/samba/netcmd/domain/level.py b/python/samba/netcmd/domain/level.py
index c4361eed342..7300561c30c 100644
--- a/python/samba/netcmd/domain/level.py
+++ b/python/samba/netcmd/domain/level.py
@@ -69,7 +69,7 @@ class cmd_domain_level(Command):
         domain_dn = samdb.domain_dn()
 
         in_transaction = False
-        if subcommand == "raise" and not H.startswith("ldap"):
+        if subcommand == "raise" and (H is None or not H.startswith("ldap")):
             samdb.transaction_start()
             in_transaction = True
             try:


-- 
Samba Shared Repository