[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Thu Apr 6 16:47:02 UTC 2023


The branch, master has been updated
       via  e3b9e252338 lib:registry: drop unused argument of reg_open_remote()
      from  c50cde0cd5e python:tests: Correctly skip some GPO tests in release tarball

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit e3b9e252338bd65ece3f7180a16db83ec9842d35
Author: Dmitry Antipov <dantipov at cloudlinux.com>
Date:   Fri Mar 17 13:06:52 2023 +0300

    lib:registry: drop unused argument of reg_open_remote()
    
    Drop 'struct auth_session_info *' argument of reg_open_remote()
    which is actually unused (NULL passed by all of the callers).
    
    Signed-off-by: Dmitry Antipov <dantipov at cloudlinux.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Joseph Sutton <josephsutton at catalyst.net.nz>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Apr  6 16:46:03 UTC 2023 on atb-devel-224

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/registry/registry.h      | 1 -
 source4/lib/registry/rpc.c           | 1 -
 source4/lib/registry/tools/common.c  | 2 +-
 source4/lib/registry/tools/regdiff.c | 3 +--
 4 files changed, 2 insertions(+), 5 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/registry/registry.h b/source4/lib/registry/registry.h
index c22038cbfa9..84173cb74ee 100644
--- a/source4/lib/registry/registry.h
+++ b/source4/lib/registry/registry.h
@@ -381,7 +381,6 @@ WERROR reg_open_samba(TALLOC_CTX *mem_ctx,
  */
 WERROR reg_open_remote(TALLOC_CTX *mem_ctx,
 		       struct registry_context **ctx,
-		       struct auth_session_info *session_info,
 		       struct cli_credentials *credentials,
 		       struct loadparm_context *lp_ctx,
 		       const char *location, struct tevent_context *ev);
diff --git a/source4/lib/registry/rpc.c b/source4/lib/registry/rpc.c
index 2f6edf3b569..a0c959f1f4f 100644
--- a/source4/lib/registry/rpc.c
+++ b/source4/lib/registry/rpc.c
@@ -538,7 +538,6 @@ static struct registry_operations reg_backend_rpc = {
 
 _PUBLIC_ WERROR reg_open_remote(TALLOC_CTX *mem_ctx,
 				struct registry_context **ctx,
-				struct auth_session_info *session_info,
 				struct cli_credentials *credentials,
 				struct loadparm_context *lp_ctx,
 				const char *location, struct tevent_context *ev)
diff --git a/source4/lib/registry/tools/common.c b/source4/lib/registry/tools/common.c
index a2fda8d48df..7fd5bd26125 100644
--- a/source4/lib/registry/tools/common.c
+++ b/source4/lib/registry/tools/common.c
@@ -31,7 +31,7 @@ struct registry_context *reg_common_open_remote(const char *remote,
 	struct registry_context *h = NULL;
 	WERROR error;
 
-	error = reg_open_remote(NULL, &h, NULL, creds, lp_ctx, remote, ev_ctx);
+	error = reg_open_remote(NULL, &h, creds, lp_ctx, remote, ev_ctx);
 
 	if (!W_ERROR_IS_OK(error)) {
 		fprintf(stderr, "Unable to open remote registry at %s:%s \n",
diff --git a/source4/lib/registry/tools/regdiff.c b/source4/lib/registry/tools/regdiff.c
index aab7b68944c..977a9745492 100644
--- a/source4/lib/registry/tools/regdiff.c
+++ b/source4/lib/registry/tools/regdiff.c
@@ -48,8 +48,7 @@ static struct registry_context *open_backend(TALLOC_CTX *mem_ctx,
 				creds);
 		break;
 	case REG_REMOTE:
-		error = reg_open_remote(mem_ctx, &ctx, NULL,
-				creds, lp_ctx,
+		error = reg_open_remote(mem_ctx, &ctx, creds, lp_ctx,
 					remote_host, ev_ctx);
 		break;
 	case REG_NULL:


-- 
Samba Shared Repository



More information about the samba-cvs mailing list