[SCM] Samba Shared Repository - branch master updated

Noel Power npower at samba.org
Fri Sep 23 09:52:01 UTC 2022


The branch, master has been updated
       via  b600b0c8d96 s3: smbd: Fix memory leak in smbd_server_connection_terminate_done().
      from  f6b391e04a4 vfs_gpfs: Protect against timestamps before the Unix epoch

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit b600b0c8d9690cb5eeded1e5925c8e667c11af04
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 14 17:05:05 2022 -0700

    s3: smbd: Fix memory leak in smbd_server_connection_terminate_done().
    
    The function smbd_server_connection_terminate_done() does not free subreq
    which is allocated in smbXsrv_connection_shutdown_send, this can be a
    memory leakage if multi-channel is enabled.
    
    Suggested fix by haihua yang <hhyangdev at gmail.com>
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15174
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Fri Sep 23 09:51:20 UTC 2022 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/smb2_server.c | 1 +
 1 file changed, 1 insertion(+)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index e8a91238baf..1cd5953f116 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -1643,6 +1643,7 @@ static void smbd_server_connection_terminate_done(struct tevent_req *subreq)
 	NTSTATUS status;
 
 	status = smbXsrv_connection_shutdown_recv(subreq);
+	TALLOC_FREE(subreq);
 	if (!NT_STATUS_IS_OK(status)) {
 		exit_server("smbXsrv_connection_shutdown_recv failed");
 	}


-- 
Samba Shared Repository



More information about the samba-cvs mailing list