[SCM] Samba Shared Repository - branch v4-17-test updated

Jule Anger janger at samba.org
Sat Sep 3 08:19:02 UTC 2022


The branch, v4-17-test has been updated
       via  e9c554c0a6a s3/winbindd: Fix bad access to sid array (with debug level >= info)
      from  3ba0c89f248 VERSION: Bump version up to Samba 4.17.0rc4...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-17-test


- Log -----------------------------------------------------------------
commit e9c554c0a6a2c0ba6d03fda7b64f19a42fae96d1
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 31 12:27:53 2022 +0100

    s3/winbindd: Fix bad access to sid array (with debug level >= info)
    
    ==6436==    at 0xA85F95B: dom_sid_string_buf (dom_sid.c:444)
    ==6436==    by 0xA85FBF2: dom_sid_str_buf (dom_sid.c:515)
    ==6436==    by 0x17EDF8: wb_lookupusergroups_recv (wb_lookupusergroups.c:115)
    ==6436==    by 0x17F964: wb_gettoken_gotgroups (wb_gettoken.c:123)
    ==6436==    by 0x56AD332: _tevent_req_notify_callback (tevent_req.c:141)
    ==6436==    by 0x56AD493: tevent_req_finish (tevent_req.c:193)
    ==6436==    by 0x56AD5C0: tevent_req_trigger (tevent_req.c:250)
    ==6436==    by 0x56AC119: tevent_common_invoke_immediate_handler (tevent_immediate.c:190)
    ==6436==    by 0x56AC268: tevent_common_loop_immediate (tevent_immediate.c:236)
    ==6436==    by 0x56B678A: epoll_event_loop_once (tevent_epoll.c:919)
    ==6436==    by 0x56B31C3: std_event_loop_once (tevent_standard.c:110)
    ==6436==    by 0x56AA621: _tevent_loop_once (tevent.c:825)
    ==6436==
    ==6436== Invalid read of size 1
    ==6436==    at 0xA85F95B: dom_sid_string_buf (dom_sid.c:444)
    ==6436==    by 0xA85FBF2: dom_sid_str_buf (dom_sid.c:515)
    ==6436==    by 0x17EDF8: wb_lookupusergroups_recv (wb_lookupusergroups.c:115)
    ==6436==    by 0x17F964: wb_gettoken_gotgroups (wb_gettoken.c:123)
    ==6436==    by 0x56AD332: _tevent_req_notify_callback (tevent_req.c:141)
    ==6436==    by 0x56AD493: tevent_req_finish (tevent_req.c:193)
    ==6436==    by 0x56AD5C0: tevent_req_trigger (tevent_req.c:250)
    ==6436==    by 0x56AC119: tevent_common_invoke_immediate_handler (tevent_immediate.c:190)
    ==6436==    by 0x56AC268: tevent_common_loop_immediate (tevent_immediate.c:236)
    ==6436==    by 0x56B678A: epoll_event_loop_once (tevent_epoll.c:919)
    ==6436==    by 0x56B31C3: std_event_loop_once (tevent_standard.c:110)
    ==6436==    by 0x56AA621: _tevent_loop_once (tevent.c:825)
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15160
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Wed Aug 31 15:07:31 UTC 2022 on sn-devel-184
    
    (cherry picked from commit 1788b59bc0aaa8f18186ad9b9945fbd634f02445)
    
    Autobuild-User(v4-17-test): Jule Anger <janger at samba.org>
    Autobuild-Date(v4-17-test): Sat Sep  3 08:18:15 UTC 2022 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/wb_lookupusergroups.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/wb_lookupusergroups.c b/source3/winbindd/wb_lookupusergroups.c
index 7ac1b6e03d2..7f359ee9316 100644
--- a/source3/winbindd/wb_lookupusergroups.c
+++ b/source3/winbindd/wb_lookupusergroups.c
@@ -113,7 +113,7 @@ NTSTATUS wb_lookupusergroups_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
 		for (i = 0; i < *num_sids; i++) {
 			struct dom_sid_buf buf;
 			D_INFO("%"PRIu32": %s\n",
-			       i, dom_sid_str_buf(&*sids[i], &buf));
+			       i, dom_sid_str_buf(&(*sids)[i], &buf));
 		}
 	}
 	return NT_STATUS_OK;


-- 
Samba Shared Repository



More information about the samba-cvs mailing list