[SCM] Samba Shared Repository - branch master updated

Noel Power npower at samba.org
Mon Jul 4 16:43:01 UTC 2022

The branch, master has been updated
       via  96a649efd8d s3: libads: Fix coverity false positive.
      from  17f8ec6f57a s4:mitkdc: Always set SDB_F_FOR_{TGS,AS}_REQ flag for DAL >= 9


- Log -----------------------------------------------------------------
commit 96a649efd8d4da05c99a67e33a2354d4f2a4ced7
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jul 1 08:49:42 2022 -0700

    s3: libads: Fix coverity false positive.
    dn is always returned as NULL on error in ads_build_path(),
    but coverity can't see that. Easy change to quieten it.
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Mon Jul  4 16:42:28 UTC 2022 on sn-devel-184


Summary of changes:
 source3/libads/ads_struct.c | 1 +
 1 file changed, 1 insertion(+)

Changeset truncated at 500 lines:

diff --git a/source3/libads/ads_struct.c b/source3/libads/ads_struct.c
index 90634effc58..97f84d124d0 100644
--- a/source3/libads/ads_struct.c
+++ b/source3/libads/ads_struct.c
@@ -106,6 +106,7 @@ ADS_STATUS ads_build_dn(const char *realm, TALLOC_CTX *mem_ctx, char **_dn)
 	status = ads_build_path(realm, ".", "dc=", 0, &dn);
 	if (!ADS_ERR_OK(status)) {
+		SAFE_FREE(dn);
 		return status;

Samba Shared Repository

More information about the samba-cvs mailing list