[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Thu Dec 1 15:04:01 UTC 2022


The branch, master has been updated
       via  49b40a13343 s4:torture: Fix segfault in multichannel test
      from  357bafe6258 smbd: Allow POSIX getinfo levels for smb3 unix extensions

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 49b40a1334353aec6febc82a09a49a7e9588e65c
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 30 18:23:17 2022 +0100

    s4:torture: Fix segfault in multichannel test
    
    The timer for the timeout_cb() handler was created on a memory context
    which doesn't get freed, so the timer was still valid when running
    the next test and fired there. It was then writing into random memory
    leading to segfaults.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Dec  1 15:03:19 UTC 2022 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source4/torture/smb2/multichannel.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/smb2/multichannel.c b/source4/torture/smb2/multichannel.c
index 24c736d6701..0c0bc5d1a7e 100644
--- a/source4/torture/smb2/multichannel.c
+++ b/source4/torture/smb2/multichannel.c
@@ -1862,7 +1862,6 @@ static bool test_multichannel_lease_break_test3(struct torture_context *tctx,
 	struct tevent_timer *te = NULL;
 	struct timeval ne;
 	bool timesup = false;
-	TALLOC_CTX *tmp_ctx = talloc_new(NULL);
 
 	if (!test_multichannel_initial_checks(tctx, tree1)) {
 		return true;
@@ -1914,7 +1913,7 @@ static bool test_multichannel_lease_break_test3(struct torture_context *tctx,
 
 	/* Set a timeout for 5 seconds for session 1 to open file1 */
 	ne = tevent_timeval_current_ofs(0, 5000000);
-	te = tevent_add_timer(tctx->ev, tmp_ctx, ne, timeout_cb, &timesup);
+	te = tevent_add_timer(tctx->ev, mem_ctx, ne, timeout_cb, &timesup);
 	if (te == NULL) {
 		torture_comment(tctx, "Failed to add timer.");
 		goto done;


-- 
Samba Shared Repository



More information about the samba-cvs mailing list