[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
       via  7880537674c s3:winbind: Fix uninitialized validation_level variable
      from  a20d41accdc tevent:tests: Test queue entry tags

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 7880537674ccfec42fb37a682dadc1a0f848947e
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Apr 12 11:48:28 2022 +0200

    s3:winbind: Fix uninitialized validation_level variable
    
    Found by oss-fuzz:
    
    ../../source3/winbindd/winbindd_pam.c:2879:7: error: variable 'validation_level' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                     if (!(state->request->flags & WBFLAG_BIG_NTLMV2_BLOB) ||
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ../../source3/winbindd/winbindd_pam.c:3003:6: note: uninitialized use occurs here
                 validation_level,
                 ^~~~~~~~~~~~~~~~
     ../../source3/winbindd/winbindd_pam.c:2879:3: note: remove the 'if' if its condition is always false
                     if (!(state->request->flags & WBFLAG_BIG_NTLMV2_BLOB) ||
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ../../source3/winbindd/winbindd_pam.c:2879:7: error: variable 'validation_level' is used uninitialized whenever '||' condition is true [-Werror,-Wsometimes-uninitialized]
                     if (!(state->request->flags & WBFLAG_BIG_NTLMV2_BLOB) ||
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ../../source3/winbindd/winbindd_pam.c:3003:6: note: uninitialized use occurs here
                 validation_level,
                 ^~~~~~~~~~~~~~~~
     ../../source3/winbindd/winbindd_pam.c:2879:7: note: remove the '||' if its condition is always false
                     if (!(state->request->flags & WBFLAG_BIG_NTLMV2_BLOB) ||
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ../../source3/winbindd/winbindd_pam.c:2853:27: note: initialize the variable 'validation_level' to silence this warning
             uint16_t validation_level;
                                      ^
                                       = 0
     1 warning and 2 errors generated.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15044
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Apr 12 18:54:50 UTC 2022 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd_pam.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
index b7d2059b193..418166af657 100644
--- a/source3/winbindd/winbindd_pam.c
+++ b/source3/winbindd/winbindd_pam.c
@@ -2850,7 +2850,7 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain,
 	uint64_t logon_id = 0;
 	uint8_t authoritative = 1;
 	uint32_t flags = 0;
-	uint16_t validation_level;
+	uint16_t validation_level = UINT16_MAX;
 	union netr_Validation *validation = NULL;
 	DATA_BLOB lm_resp = { 0 }, nt_resp = { 0 };
 	const struct timeval start_time = timeval_current();


-- 
Samba Shared Repository